Repository navigation
fix: validate ams bot tokens in naming convention tests - #9943
Draft
prajwalu142 wants to merge 1 commit into
Draft
prajwalu142 wants to merge 1 commit into
prajwalu142 wants to merge 1 commit into
Conversation
Contributor
|
|
Contributor
ralph-bitgo
Bot
force-pushed
the
fix/addBotTokenEntriesToNamingTests
branch
from
October 13, 2026 20:10
04ce734 to
41d75b3
Compare
prajwalu142
marked this pull request as ready for review
October 14, 2026 06:41
prajwalu142
force-pushed
the
fix/addBotTokenEntriesToNamingTests
branch
2 times, most recently
from
October 14, 2026 06:47
daee065 to
f02a928
Compare
AMS tokens were missing from the name convention tests which caused issues downstream.Pass them in the test file which ensures the conventions aren't broken Ticket: CSHLD-1931
prajwalu142
force-pushed
the
fix/addBotTokenEntriesToNamingTests
branch
from
October 14, 2026 06:48
f02a928 to
6db7d7a
Compare
prajwalu142
marked this pull request as draft
October 14, 2026 06:49
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the naming convention tests skip ams tokens. Add botTokens and botOfcTokens to the naming tests so that any bad entry is caught early.
What changed
botTokensandbotOfcTokensin theallTokenslist ofmodules/statics/test/unit/tokenNamingConvention.ts, so AMS-onboarded tokens flow through the same naming validations as every other token.../../src/coins/...). The previous non-relativemodules/statics/...imports were resolved as an external package namedmodules, which is what failed thecode-quality (dependencies)check.t-prefix and mainnett-rules to the underlying coin name for OFC tokens, which are namedofc+ the coin name (e.g.ofctsol:usdcisofc+tsol:usdc). Correctly named OFC entries pass, and only genuine deviations surface — otherwise every future correctly named OFC testnet token would fail the rawtrule and need a permanent exception.htethon-chain symbol names such ashteth:WBTC,ethx1, and theWBTCcasing) in the exception lists, matching how earlier AMS tokens were handled. No token definitions were changed — e.g.hteth:wbtcalready exists inerc20Coins, sohteth:WBTCcannot be renamed without colliding.Why
Auto-AMS onboarded tokens bypassed every naming validation because the naming tests did not include the bot token lists, so bad entries could ship unnoticed (see the thread referenced in CSHLD-1931). With this change, future AMS entries are validated on arrival; only the listed pre-existing entries are exempted.
Verification
@bitgo/staticsunit suite: 39,670 passing, 0 failing (includes the 5 token naming convention tests and the 4 OFC naming tests)yarn run check-depspasses (previously failed on the phantommodulespackage)prettier --checkclean inmodules/staticsTicket: CSHLD-1931