Skip to content

fix: bump fflate and stellar-sdk to resolve OSV HIGH/CRITICAL #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lokesh-bitgo wants to merge 1 commit into
base: master
Choose a base branch
from
+100 −105
Draft

fix: bump fflate and stellar-sdk to resolve OSV HIGH/CRITICAL #9653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/bitgo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"bignumber.js": "^9.1.1",
"lodash": "^4.18.0",
"openpgp": "5.11.3",
"stellar-sdk": "^10.0.1",
"stellar-sdk": "^13.0.0",
"superagent": "^9.0.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-algo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"joi": "^17.4.0",
"js-sha512": "0.8.0",
"lodash": "^4.18.0",
"stellar-sdk": "^10.0.1",
"stellar-sdk": "^13.0.0",
"tweetnacl": "^1.0.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-hbar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"lodash": "^4.18.0",
"long": "^5.2.3",
"protobufjs": "^7.5.8",
"stellar-sdk": "^10.0.1",
"stellar-sdk": "^13.0.0",
"tweetnacl": "^1.0.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-xlm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@bitgo/statics": "^59.12.0",
"bignumber.js": "^9.1.1",
"lodash": "^4.18.0",
"stellar-sdk": "^10.0.1",
"stellar-sdk": "^13.0.0",
"superagent": "^9.0.1"
},
"devDependencies": {
Expand Down
14 changes: 7 additions & 7 deletions modules/sdk-coin-xlm/src/xlm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export class Xlm extends BaseCoin {
* @returns minimum balance in stroops
*/
async getMinimumReserve(): Promise<number> {
const server = new stellar.Server(this.getHorizonUrl());
const server = new stellar.Horizon.Server(this.getHorizonUrl());

const horizonLedgerInfo = await server.ledgers().order('desc').limit(1).call();

Expand All @@ -451,7 +451,7 @@ export class Xlm extends BaseCoin {
* @returns transaction fee in stroops
*/
async getBaseTransactionFee(): Promise<number> {
const server = new stellar.Server(this.getHorizonUrl());
const server = new stellar.Horizon.Server(this.getHorizonUrl());

const horizonLedgerInfo = await server.ledgers().order('desc').limit(1).call();

Expand Down Expand Up @@ -599,11 +599,11 @@ export class Xlm extends BaseCoin {
*
* @returns instance of BitGo Federation Server
*/
getBitGoFederationServer(): stellar.FederationServer {
getBitGoFederationServer(): stellar.Federation.Server {
// Identify the URI scheme in case we need to allow connecting to HTTP server.
const isNonSecureEnv = !_.startsWith(common.Environments[this.bitgo.env].uri, 'https');
const federationServerOptions = { allowHttp: isNonSecureEnv };
return new stellar.FederationServer(this.getFederationServerUrl(), 'bitgo.com', federationServerOptions);
return new stellar.Federation.Server(this.getFederationServerUrl(), 'bitgo.com', federationServerOptions);
}

/**
Expand All @@ -619,7 +619,7 @@ export class Xlm extends BaseCoin {
}: {
address?: string;
accountId?: string;
}): Promise<stellar.FederationServer.Record> {
}): Promise<stellar.Federation.Api.Record> {
try {
const federationServer = this.getBitGoFederationServer();
if (address) {
Expand All @@ -644,7 +644,7 @@ export class Xlm extends BaseCoin {
*
* @param {String} address - stellar address to look for
*/
async federationLookupByName(address: string): Promise<stellar.FederationServer.Record> {
async federationLookupByName(address: string): Promise<stellar.Federation.Api.Record> {
if (!address) {
throw new Error('invalid Stellar address');
}
Expand All @@ -658,7 +658,7 @@ export class Xlm extends BaseCoin {
*
* @param {String} accountId - stellar account id
*/
async federationLookupByAccountId(accountId: string): Promise<stellar.FederationServer.Record> {
async federationLookupByAccountId(accountId: string): Promise<stellar.Federation.Api.Record> {
if (!accountId) {
throw new Error('invalid Stellar account');
}
Expand Down
7 changes: 1 addition & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"**/sha.js": ">=2.4.12",
"**/serialize-javascript": "7.0.5",
"jspdf": ">=4.2.1",
"fflate": "0.8.3",
"@ethereumjs/util": "8.0.3",
"@types/keyv": "3.1.4",
"@types/react": "17.0.24",
Expand Down Expand Up @@ -260,12 +261,6 @@
"express": {
"path-to-regexp": "0.1.13"
},
"stellar-sdk": {
"bignumber.js": "4.1.0"
},
"stellar-base": {
"bignumber.js": "4.1.0"
},
"avalanche": {
"ws": "8.18.3",
"store2": "2.14.4"
Expand Down
Loading
Loading