fix: bump fflate to 0.8.3 and toml to 4.3.0 (osv-scanner CVSS 7.0+ gate) - #9652
Merged
Conversation
fflate@0.8.2 (via key-card > jspdf) hit GHSA-px8p-9vwx-vf98 (CVSS 7.5, unzipSync infinite loop on malformed ZIP64 archives). toml@2.3.6 (via bitgo > stellar-sdk) hit GHSA-82x6-q7mm-w9cf and GHSA-v5mp-jgw5-2x6j (CVSS 7.5/8.2, recursion DoS and prototype pollution in toml.parse()). Both were failing the release's "3 of N advisory groups >= CVSS 7.0" gate. Verified via full monorepo install + build that the bumps do not break jspdf's zlibSync usage or stellar-sdk's toml.parse() call shape. Ticket: CECHO-2099
Contributor
lokesh-bitgo
approved these changes
Sep 4, 2026
diksha190
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release's osv-scanner "Enforce Vulnerability Severity Threshold" gate was failing on 3 advisory groups at CVSS >= 7.0:
fflate@0.8.2(transitive via@bitgo/key-card>jspdf) — GHSA-px8p-9vwx-vf98 (CVSS 7.5):unzipSynccan infinite-loop on a malformed ZIP64 archive.toml@2.3.6(transitive viabitgo>stellar-sdk) — GHSA-82x6-q7mm-w9cf (CVSS 7.5): uncontrolled recursion DoS intoml.parse().toml@2.3.6— GHSA-v5mp-jgw5-2x6j (CVSS 8.2): prototype pollution via__proto__key-path desync intoml.parse().Fixed by pinning both via root
resolutions:fflate->0.8.3(patch release with the fix)toml->4.3.0(latest 4.x, includes both fixes)Verification
yarn install+ build succeeded with both pins in place.jspdfonly callsfflate.zlibSync(compression) — neverunzipSync— so the bump carries no behavioral risk there.stellar-sdk'stoml.parse()call shape (require("toml").default.parse(text)) is unchanged in 4.3.0 (still CJS,main: index.js); confirmed with a standalone parse test.StellarTomlResolver/FederationServer.createForDomain) — we don't; our XLM federation lookups use a fixed BitGo URL — but bumping to the patched version was safer/cleaner than an exclusion here since it verified cleanly, unlike tar's exclusion-only case elsewhere inosv-scanner.toml.Test plan
yarn installsucceeds, full monorepo build succeedsfflateresolves to0.8.3,tomlresolves to4.3.0(yarn why)