fix(sdk-coin-sui): preserve custom transaction amount precision - #9604
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
fix(sdk-coin-sui): preserve custom transaction amount precision#9604ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Aggregate custom transaction recipient amounts with BigNumber instead of converting external u64 values to JavaScript numbers. Add a regression test and document the cross-coin audit findings because rounded Sui amounts can produce incorrect transaction explanations and input totals. Ticket: CSHLD-1018 Session-Id: c3c753a4-4f1a-4c00-a472-9e69452eb9da Task-Id: 9ebc0ba0-6ecb-47d2-854b-bad260bb0691
Contributor
ralph-bitgo
Bot
force-pushed
the
CSHLD-1018-audit-precision
branch
from
August 31, 2026 08:12
db1383c to
e234704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sui custom transaction recipient amounts can exceed JavaScript's safe integer limit. Converting those external u64 strings with
Number()rounded transaction input totals and explanations.What
BigNumberand preserve fixed-point string output.Number.MAX_SAFE_INTEGER.Ticket: CSHLD-1018