Repository navigation
Phones: a launch never puts a sheet back over the app - #85
Merged
Merged
Conversation
The phone keeps its whole client state (every 30 s and when it goes to the background) and loads it at the next launch. Hubs.stale only marked it unsynced, so whatever was up when it was kept came back over the app: reproduced with real taps (XCUITest, Release build) by leaving Search threads open, relaunching, and finding the uberbot's card covered and untappable. Hubs.calm, applied on load, shuts Find, Settings, the pairing QR, the key form and the folder picker, the row menu, the delete/remove/rename questions, the bot/room/routine forms and an error; the selection and drafts stay. Android loads through the same bridge. test/mcalm_test.bend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone keeps its whole Bend client state (every 30 s, and when it goes to the background) and loads it at the next launch (
Backplane.load→Hubs.stale).Hubs.staleonly marked the state unsynced, so any sheet, menu, form or error that was up when it was kept came back over the app at every launch.Reproduced with real taps (a new XCUITest runner driving the Release build of TestFlight 202610131602, paired by link): More → Search threads, wait for the state to be kept, kill and relaunch. "Search threads" covers the whole app, and the uberbot's card exists but isn't hittable.
Fix:
Hubs.calm, applied on load, closes Find (palette), Settings, the pairing QR, the key form and the folder picker (flags), plus the row menu, the delete/remove/rename questions and the bot/room/routine forms (scratch), and clears the error. The selection and drafts stay. Android loads through the same bridge (and on its V8 reset), so it's covered too.Tests: new
test/mcalm_test.bend(Find, Settings and the bot form open, then all closed after the load path, with the selection kept);mnavandhubspass; bridge.js and the release APK build. The real-tap repro on the fixed build is the merge gate.🤖 Generated with Claude Code