Fix Package Requirements for Nuget Core Package

[RubenCerna2079]

Why make this change?

• Solves issue Fix Core.csproj Package Requirements #3618

What is this change?

This adds TargetsForTfmSpecificContentInPackage and IncludeInternalDependenciesInPackage to create the dependencies from the Core project as dlls. And uses the PrivateAssets to ensure that those dependencies are not added to the nuspec file.

How was this tested?

• Integration Tests
• Unit Tests
• Manual Tests
  Tested by using command dotnet pack .\Azure.DataApiBuilder.Core.csproj -c Release to build nuget package and ensure that all the dependencies are created as expected.

Sample Request(s)

N/A

[Copilot]

Pull request overview

Updates the Core NuGet packaging logic so the Microsoft.DataApiBuilder.Core package includes internal dependency assemblies during dotnet pack, addressing a broken Core package that previously omitted required DLLs.

Changes:

• Adds a custom pack target (IncludeInternalDependenciesInPackage) and wires it into TargetsForTfmSpecificContentInPackage.
• Marks Core’s internal ProjectReferences as PrivateAssets="all" to avoid emitting them as NuGet dependencies.
• Packs reference assemblies into lib/<tfm> via TfmSpecificPackageFile.

Comments suppressed due to low confidence (2)

src/Core/Azure.DataApiBuilder.Core.csproj:74

• The target is including all @(ReferenceCopyLocalPaths) into the package. That typically includes copy-local assemblies from NuGet package references as well as project references, which can massively bloat the nupkg and create assembly version/conflict risks (and may have licensing/NOTICE implications). If the goal is only to embed internal project-reference outputs (Auth/Config/GraphQLBuilder), filter the item list to those (e.g., by metadata indicating project references or by limiting to the referenced projects’ output paths/assembly names).

  <Target Name="IncludeInternalDependenciesInPackage">
      <ItemGroup>
        <TfmSpecificPackageFile Include="@(ReferenceCopyLocalPaths)" PackagePath="lib/$(TargetFramework)" Condition="'%(ReferenceCopyLocalPaths.Extension)' != '.pdb'" />
    </ItemGroup>

src/Core/Azure.DataApiBuilder.Core.csproj:75

• Indentation within the new <Target> block is inconsistent (extra indentation before <ItemGroup> and misaligned closing tag), which can make future edits/error spotting harder. Please align indentation with the rest of the project file.

  <Target Name="IncludeInternalDependenciesInPackage">
      <ItemGroup>
        <TfmSpecificPackageFile Include="@(ReferenceCopyLocalPaths)" PackagePath="lib/$(TargetFramework)" Condition="'%(ReferenceCopyLocalPaths.Extension)' != '.pdb'" />
    </ItemGroup>
  </Target>

[aaronburtle]

Looks good!