Skip to content

Temporarily remove OneSettings configuration manager to prevent user disruptions during feature testing#44179

Merged
rads-1996 merged 7 commits into
Azure:mainfrom
rads-1996:comment-onesettings-changes
Nov 25, 2025
Merged

Temporarily remove OneSettings configuration manager to prevent user disruptions during feature testing#44179
rads-1996 merged 7 commits into
Azure:mainfrom
rads-1996:comment-onesettings-changes

Conversation

@rads-1996
Copy link
Copy Markdown
Member

Description

Temporarily remove OneSettings configuration manager to prevent user disruptions during feature testing

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Copilot AI review requested due to automatic review settings November 25, 2025 18:05
@github-actions github-actions Bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Nov 25, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR temporarily removes the OneSettings configuration manager initialization from the base exporter to prevent user disruptions during feature testing. The change removes the configuration manager setup from the exporter's initialization process while preserving the functionality for other parts of the codebase that still depend on it (like live metrics and statsbeat). This is a non-breaking internal change that affects how the exporter initializes but doesn't impact the public API.

  • Removed OneSettings configuration manager initialization from BaseExporter
  • Cleaned up unused imports related to configuration manager utilities
  • Updated CHANGELOG with appropriate entry under "Other Changes"

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py Removed configuration manager initialization and related imports from BaseExporter.init()
sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md Added entry documenting the temporary removal of OneSettings configuration manager

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@JacksonWeber
Copy link
Copy Markdown
Member

What kind of disruptions was this causing prior? Just want to understand the scope of the change here.

@rads-1996
Copy link
Copy Markdown
Member Author

What kind of disruptions was this causing prior? Just want to understand the scope of the change here.

The users were getting warnings about version mismatch, and the warnings were very frequent and causing unnecessary amounts of traces.

@rads-1996 rads-1996 force-pushed the comment-onesettings-changes branch from b772436 to 61872a1 Compare November 25, 2025 20:45
@rads-1996 rads-1996 merged commit d564329 into Azure:main Nov 25, 2025
20 checks passed
@rads-1996 rads-1996 deleted the comment-onesettings-changes branch November 25, 2025 21:11
msyyc pushed a commit that referenced this pull request Nov 26, 2025
…disruptions during feature testing (#44179)

* Temporarily remove OneSettings configuration manager to prevent user disruptions during feature testing

* Updated CHANGELOG

* Addressed feedback

* Remove extra line

* Addressed feedback

* Remove extra line

* Remove extra line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants