Repository navigation
[Storage] STG105 Share Creation Time on Get Share Properties and List Shares - #50652
Open
browndav-msft wants to merge 12 commits into
Open
browndav-msft wants to merge 12 commits into
browndav-msft wants to merge 12 commits into
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 34 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Isabelle (ibrandes)
marked this pull request as ready for review
October 6, 2026 20:32
Isabelle (ibrandes)
requested review from
a team,
Alan Zimmer (alzimmermsft),
gunjansingh-msft,
Isabelle (ibrandes),
Kyle Knapp (kyleknap) and
Sean McCullough (seanmcc-msft)
as code owners
October 6, 2026 20:32
Isabelle (ibrandes)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Public XML serialization uses the wrong element name, and the new public API is missing from the changelog.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds share creation-time support to get-properties and list-shares operations.
Changes:
- Updates the service specification and generated models.
- Maps creation time into public share properties.
- Adds synchronous, asynchronous, and model tests.
| File | Description |
|---|---|
swagger/README.md |
Updates specification and XML mapping. |
ShareAsyncApiTests.java |
Tests asynchronous get-properties. |
ShareApiTests.java |
Tests synchronous get-properties. |
ModelTests.java |
Tests model mappings. |
FileServiceAsyncApiTests.java |
Tests asynchronous list-shares. |
FileServiceApiTests.java |
Tests synchronous list-shares. |
ShareProperties.java |
Exposes creation time publicly. |
ModelHelper.java |
Maps creation time into public models. |
SharesGetPropertiesHeaders.java |
Deserializes the creation-time header. |
SharePropertiesInternal.java |
Deserializes list-shares creation time. |
assets.json |
Updates test recordings. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Isabelle (ibrandes)
left a comment
Isabelle (ibrandes)
left a comment
Member
There was a problem hiding this comment.
please address the open copilot comments and add a test for the deserialization issue that it ran into :)
…chema name update
…/azure-sdk-for-java into stg105/creation-time
Isabelle (ibrandes)
self-requested a review
October 12, 2026 18:30
Isabelle (ibrandes)
approved these changes
Oct 12, 2026
Isabelle (ibrandes)
left a comment
Isabelle (ibrandes)
left a comment
Member
There was a problem hiding this comment.
looks good to me! let's wait to merge this in until after the API view meeting though, in case they request any changes.
…)" This reverts commit 83dc6e2.
… stg105/creation-time # Conflicts: # sdk/storage/azure-storage-file-share/CHANGELOG.md # sdk/storage/azure-storage-file-share/assets.json # sdk/storage/azure-storage-file-share/swagger/README.md
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.