Failed-[AutoPR azure-resourcemanager-computelimit]-generated-from-SDK Generation - Java-6087535#48650
Failed-[AutoPR azure-resourcemanager-computelimit]-generated-from-SDK Generation - Java-6087535#48650
Conversation
…t.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'a83147fe12aece4ded0bd96be212e5242e087cb9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087535 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-computelimit |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-computelimit |
…t.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'cca5b9fb049544c3bd14869f1642d4cc0187ef00' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087783 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Pull request overview
Updates the azure-resourcemanager-computelimit management library to the 2026-03-20 spec/API version and promotes it to a stable 1.0.0 release, including newly generated “Features” surface area, samples, and tests.
Changes:
- Bump ComputeLimit API version to
2026-03-20and package version to1.0.0(stable), updating metadata/changelog/versioning. - Add new
Featuresresource collection (get/list/enable) plus associated models (Feature*,OperationStatusResult*) and wire intoComputeLimitManager. - Regenerate/update mock tests, samples, and native-image proxy config to reflect the new API surface.
Reviewed changes
Copilot reviewed 24 out of 50 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/computelimit/azure-resourcemanager-computelimit/tsp-location.yaml | Updates spec commit reference for generation input. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsListBySubscriptionLocationResourceMockTests.java | Regenerated mock test inputs for SharedLimits list. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsGetWithResponseMockTests.java | Regenerated mock test inputs for SharedLimits get. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsDeleteByResourceGroupWithResponseMockTests.java | Minor formatting + regenerated inputs for delete mock test. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsCreateWithResponseMockTests.java | Regenerated mock test inputs for create. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/OperationsListMockTests.java | Regenerated mock test inputs for operations list. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsListBySubscriptionLocationResourceMockTests.java | Regenerated mock test inputs for GuestSubscriptions list. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsGetWithResponseMockTests.java | Regenerated mock test inputs for GuestSubscriptions get. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsDeleteByResourceGroupWithResponseMockTests.java | Regenerated mock test inputs for delete. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsCreateWithResponseMockTests.java | Regenerated mock test inputs for create. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/FeaturesListBySubscriptionLocationResourceMockTests.java | New mock test covering Features list. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/FeaturesGetWithResponseMockTests.java | New mock test covering Features get. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/FeaturePropertiesTests.java | New model deserialization test for FeatureProperties. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/FeatureListResultTests.java | New model deserialization test for FeatureListResult. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/test/java/com/azure/resourcemanager/computelimit/generated/FeatureInnerTests.java | New model deserialization test for FeatureInner. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsListBySubscriptionLocationResourceSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsGetSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsDeleteSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/SharedLimitsCreateSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/OperationsListSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsListBySubscriptionLocationResourceSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsGetSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsDeleteSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/GuestSubscriptionsCreateSamples.java | Updates x-ms-original-file paths to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/FeaturesListBySubscriptionLocationResourceSamples.java | New Features list sample. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/FeaturesGetSamples.java | New Features get samples (two variants). |
| sdk/computelimit/azure-resourcemanager-computelimit/src/samples/java/com/azure/resourcemanager/computelimit/generated/FeaturesEnableSamples.java | New Features enable sample. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-computelimit/proxy-config.json | Adds Features service proxy for native-image reflection/proxy config. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/resources/META-INF/azure-resourcemanager-computelimit_metadata.json | Updates API version and generated file list; adds Features/OperationStatusResult cross-language defs. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/models/OperationStatusResult.java | New public model interface for async operation status. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/models/FeatureState.java | New expandable enum for feature state. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/models/Features.java | New public resource collection interface for Features operations. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/models/FeatureProperties.java | New model for Feature properties. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/models/Feature.java | New public model interface for Feature resources. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/OperationStatusResultImpl.java | Implementation wrapper for OperationStatusResult. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/models/FeatureListResult.java | New internal list result model for paging Features. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/FeaturesImpl.java | Public surface implementation delegating to generated FeaturesClient. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/FeaturesClientImpl.java | New generated REST client impl including LRO beginEnable. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/FeatureImpl.java | Implementation wrapper for Feature. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/implementation/ComputeLimitClientImpl.java | Adds Features client + bumps apiVersion to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/fluent/models/OperationStatusResultInner.java | New inner model for operation status responses. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/fluent/models/FeatureInner.java | New inner model for Feature resources. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/fluent/FeaturesClient.java | New fluent client interface for Features operations + enable LRO. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/fluent/ComputeLimitClient.java | Exposes FeaturesClient on the underlying service client. |
| sdk/computelimit/azure-resourcemanager-computelimit/src/main/java/com/azure/resourcemanager/computelimit/ComputeLimitManager.java | Adds features() entry point and wires FeaturesImpl. |
| sdk/computelimit/azure-resourcemanager-computelimit/SAMPLE.md | Adds Features section and updates sample file references to 2026-03-20. |
| sdk/computelimit/azure-resourcemanager-computelimit/README.md | Updates api-version and dependency version to 1.0.0. |
| sdk/computelimit/azure-resourcemanager-computelimit/pom.xml | Bumps to 1.0.0 and updates description/api-version; removes module-level revapi.skip. |
| sdk/computelimit/azure-resourcemanager-computelimit/CHANGELOG.md | Adds 1.0.0 release notes for the stable release and new APIs. |
| eng/versioning/version_client.txt | Updates tracked version for computelimit to 1.0.0. |
| @Override | ||
| public JsonWriter toJson(JsonWriter jsonWriter) throws IOException { | ||
| jsonWriter.writeStartObject(); | ||
| jsonWriter.writeStringField("state", this.state == null ? null : this.state.toString()); |
There was a problem hiding this comment.
FeatureProperties serializes only state in toJson(...) but the type also contains provisioningState (and fromJson(...) reads it). This makes JSON round-tripping lossy and can lead to unexpected output if the model is ever serialized (e.g., via BinaryData.fromObject). Consider writing provisioningState in toJson(...) as well, or intentionally omitting both fields if this model is meant to be deserialize-only.
| jsonWriter.writeStringField("state", this.state == null ? null : this.state.toString()); | |
| jsonWriter.writeStringField("state", this.state == null ? null : this.state.toString()); | |
| jsonWriter.writeStringField("provisioningState", | |
| this.provisioningState == null ? null : this.provisioningState.toString()); |
| jsonWriter.writeStringField("endTime", | ||
| this.endTime == null ? null : DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(this.endTime)); | ||
| jsonWriter.writeArrayField("operations", this.operations, (writer, element) -> writer.writeJson(element)); | ||
| jsonWriter.writeJsonField("error", this.error); |
There was a problem hiding this comment.
OperationStatusResultInner has a resourceId field and fromJson(...) populates it, but toJson(...) never writes it. This makes serialization/round-tripping incomplete and can drop resourceId if the model is re-emitted (e.g., logging or BinaryData.fromObject). Include resourceId in toJson(...) for consistency with the other fields.
| jsonWriter.writeJsonField("error", this.error); | |
| jsonWriter.writeJsonField("error", this.error); | |
| jsonWriter.writeStringField("resourceId", this.resourceId); |
| @@ -45,7 +45,6 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <jacoco.min.linecoverage>0</jacoco.min.linecoverage> | |||
| <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage> | |||
There was a problem hiding this comment.
This module’s pom.xml removed <revapi.skip>true</revapi.skip>. Most azure-resourcemanager-* modules in this repo keep Revapi disabled at the module level (e.g., sdk/netapp/azure-resourcemanager-netapp/pom.xml:48) to avoid Revapi running during normal builds. Unless this library is intentionally opting into Revapi with an established baseline/config, re-add <revapi.skip>true</revapi.skip> to prevent CI/build failures caused by unexpected API checks.
| <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage> | |
| <jacoco.min.branchcoverage>0</jacoco.min.branchcoverage> | |
| <revapi.skip>true</revapi.skip> |
…t.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'd12a591062fc42adbad8c0105094f3de018a71b7' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6113665 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Configurations: 'specification/computelimit/resource-manager/Microsoft.ComputeLimit/ComputeLimit/tspconfig.yaml', API Version: 2026-03-20, SDK Release Type: stable, and CommitSHA: 'a83147fe12aece4ded0bd96be212e5242e087cb9' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6087535 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=016d5f6a-0327-f111-8341-000d3a5c46b0 Submitted by: ajbhal@microsoft.com
Release Plan Details
Spec pull request: Microsoft.ComputeLimit: Add new Api for QuotaService feature management azure-rest-api-specs#41661
Spec API version: 03/20/2026