[AKS] az aks create/update Add support for ACNS performance#33018
[AKS] az aks create/update Add support for ACNS performance#33018
az aks create/update Add support for ACNS performance#33018Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
santhoshmprabhu
changed the title
az aks create/update Add support for ACNS performance
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Please commit the recording files according to your newly added test cases to pass the CI checks. You can find the recording files from pipeline artifact (live test reports/cli-recordings)
|
Let us not merge this immediately, investigating a potential bug. Marking as draft to avoid merging. |
|
Fixed the issue, live test running. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
seems you missed to commit the recording file for this test case @santhoshmprabhu |
| return self.raw_param.get("network_dataplane") | ||
|
|
||
| def get_acns_enablement(self) -> Tuple[ | ||
| def get_acns_enablement_with_perf(self) -> Tuple[ |
There was a problem hiding this comment.
will this change break the function call in cli-extensions/aks-preview?
There was a problem hiding this comment.
The original one would have. I am now using the same function signature throughout. Eventually we'll want to replace all use of get_acns_enablement_with_perf with get_acns_enablement.
I wanted to check in the right recording, since I had modified the test. Just added it now. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az aks create --enable-acns --network-plugin azure --network-dataplane cilium
Description
This pull request adds the changes for general availability of ACNS Performance features in Azure Kubernetes Service. ACNS stands for Advanced Container Networking Services. ACNS Performance is Azure's managed offering of Cilium CNI with eBPF host routing mode enabled. In this PR, we allow users to pass an enum to configure the so-called acceleration mode, using the CLI option
--acns-datapath-acceleration-mode. Possible values areBpfVethmeaning that eBPF host routing is enabled, orNone, meaning that it is not enabled. The feature requires the broader ACNS feature to be enabled (--enable-acns). Even when ACNS is enabled, the feature is disabled by default.Testing Guide
az aks create -g myRG -n myCluster --network-dataplane cilium --network-plugin azure --enable-acns --acns-datapath-acceleration-mode BpfVethcreates a cluster with ACNS performance enabled.
az aks update-g myRG -n myCluster --enable-acns --acns-datapath-acceleration-mode BpfVethenables ACNS performance on myCluster.
az aks update-g myRG -n myCluster --enable-acns --acns-datapath-acceleration-mode Nonedisables ACNS performance on myCluster, while keeping the rest of ACNS enabled.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.