Handle noisy wordpress.bench result output#961
Open
chubes4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wp-codebox/bench-results/v1JSON from successfulwordpress.benchstdout when PHP/WordPress warning text is printed before or after the structured envelope.benchResults.diagnosticsso warnings remain visible without corrupting recipe-run parsing.recipe-bench-smokewith a fixture workload that emits warning-like HTML before valid bench JSON.Fixes #959.
Validation
npm run buildnpx tsx scripts/recipe-bench-smoke.tsAI assistance
wordpress.benchrecipe-run parsing path, drafted the parser fix and targeted smoke coverage, and ran validation commands. Chris remains responsible for review and merge.