Repository navigation
Cherrypick PR #47: Fix cad_mesh_grading_factor to accept float values and remove GradingFactor enum - #53
Merged
Conversation
… and remove GradingFactor enum Co-authored-by: osinjoku <49887472+osinjoku@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Cherrypick changes from PR #47 into main branch
Cherrypick PR #47: Fix cad_mesh_grading_factor to accept float values and remove GradingFactor enum
Dec 12, 2025
osinjoku
marked this pull request as ready for review
December 12, 2025 06:17
osinjoku
approved these changes
Dec 12, 2025
sankalps0549
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cherrypicks changes from PR #47 (merged to release/26) into main. The
cad_mesh_grading_factorproperty incorrectly used aGradingFactorenum restricting values toSLOW=0andFAST=1. The underlying COM API acceptsdoublefrom 0.0 to 1.0 for continuous mesh transition control.Changes:
GradingFactorenum fromcommon.pyand__init__.pycad_mesh_grading_factorsetter to acceptfloatwith range validation [0, 1]grading_factor.rstdocumentationBefore:
After:
Type of change
Checklist
Testing
Tests validate float range and type checking:
Additional Notes
Breaking Change: Code using
GradingFactor.SLOWorGradingFactor.FASTmust update to0.0or1.0. Enum imports will fail.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.