[PE-7307, PE-7308] Add coin redeem pages by Kyle-Shanks · Pull Request #13390 · AudiusProject/apps

Kyle-Shanks · 2025-11-07T22:05:42Z

Description

Add redeem page on web
Add redeem screen on mobile
Sets up deep linking on mobile to go to redeem screen
Add hooks for fetching the reward amount with and without code
Add hooks for claiming coin rewards with and without code
Some other stuff

How Has This Been Tested?

Needs more testing when SDK is updated

changeset-bot · 2025-11-07T22:05:47Z

⚠️ No Changeset found

Latest commit: d931156

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dharit-tan · 2025-11-07T22:07:45Z

+      } catch (error) {
+        // Handle 400 errors
+        // Tells us if disburements for the coin have ended
+        if (error instanceof ResponseError) {


could have stricter check here

Yeah this should probably check the status code and the error message specifically.

dharit-tan · 2025-11-07T22:08:31Z

+
+      return response
+    },
+    onSettled: (_, __, { mint }) => {


mighttt need optimistic update, probably doesn't matter super much tho?

thought of this, but i dont know what i would update. I guess we could optimistically add the reward to the users coin balance, but seems overkill

yeah would need amount. but watevs

dharit-tan · 2025-11-07T22:09:33Z

+import { BannerSection } from '../coin-details-screen/components/CoinInfoCard'
+
+const messages = {
+  title: (ticker: string) => `Redeem $${ticker}`,


sure the ticker doesn't already have $ on it? try with a prod coin, staging coins might be out of date

no dollar sign on tickers by default

dharit-tan · 2025-11-07T22:10:26Z

+    >
+      <ScreenContent>
+        <ScrollView>
+          <Flex column gap='m' ph='s' pv='2xl'>


nit: column is default

dharit-tan · 2025-11-07T22:10:44Z

+              <Flex column gap='xs'>
+                <Text variant='heading'>{coin?.name}</Text>
+                {rewardAmountPending ? (
+                  <Box h={16} w={64}>


nit: spacing vars

dharit-tan · 2025-11-07T22:10:57Z

+}
+
+type PageContentProps = {
+  coin: Coin | undefined


dharit-tan

can u remind me the diff between code vs non-code redemptions?

dylanjeffers

looks excellent!

dylanjeffers · 2025-11-08T00:01:33Z

+      })
+      queryClient.invalidateQueries({
+        queryKey: [QUERY_KEYS.artistCoinMembers, mint]
+      })


dylanjeffers · 2025-11-08T00:01:57Z

+        feature: Feature.ArtistCoins
+      })
+
+      // TODO: Should 'Please try again' be added to the end of the message?


something to figure out now?

dylanjeffers · 2025-11-08T00:02:11Z

          // Normalize ticker to uppercase
          const normalizedTicker = ticker.toUpperCase()
+
+          if (coinRoute === 'redeem') {


dylanjeffers · 2025-11-08T00:02:36Z

+import { BannerSection } from '../coin-details-screen/components/CoinInfoCard'
+
+const messages = {
+  title: (ticker: string) => `Redeem $${ticker}`,


no dollar sign on tickers by default

…ming, and connect claim buttons

schottra · 2025-11-10T15:38:28Z

+      } catch (error) {
+        // Handle 400 errors
+        // Tells us if disburements for the coin have ended
+        if (error instanceof ResponseError) {


Yeah this should probably check the status code and the error message specifically.

schottra · 2025-11-10T15:39:39Z

+      } catch (error) {
+        // Handle 400 errors
+        // Tells us if the code is invalid or already redeemed
+        if (error instanceof ResponseError) {


This should have the same error shape as the info endpoint (tells you if invalid or already used), so also want to check 400 cases explicitly here.

schottra · 2025-11-10T15:40:10Z

+        mint,
+        userId: Id.parse(currentUserId),
+        code
+      })


This needs 400 error handling similar to the other calls.

shouldn't be getting here if the code in the first place if the code is used or invalid so no need for special cases

### Description * Add redeem page on web * Add redeem screen on mobile * Sets up deep linking on mobile to go to redeem screen * Add hooks for fetching the reward amount with and without code * Add hooks for claiming coin rewards with and without code * Some other stuff ### How Has This Been Tested? Needs more testing when SDK is updated

[16d4c68] [PE-7289] Add artist social links on coin create (#13435) Dylan Jeffers [714814d] [PE-7320] Add copy link coin overflow option (#13440) KJ [108cdc1] [PE-7335] Increase slippage to 2% (#13432) Dylan Jeffers [8a59173] [PE-7025] Fix optimistic fee claiming not working (#13431) JD Francis [5e6438e] [PE-7336] Fix stripe mobile on-ramp visibility (#13439) Dylan Jeffers [c6488b4] Revert "Increase max file size for uploads (#13430)" (#13436) Marcus Pasell [f0d22bf] Drop trading volume launch banner (#13434) Dylan Jeffers [e2d6f9e] Increase max file size for uploads (#13430) Marcus Pasell [e16832d] [PE-7286] Update portfolio balance error text color (#13429) Dylan Jeffers [92ee20d] [PE-7324] Prevent portfolio balance hovering from swiping page (#13426) Dylan Jeffers [d520d7b] [PE-7287] Fix artist-coin description color (#13425) Dylan Jeffers [c1bc62d] [PE-7315] Drop verify flow (#13410) Dylan Jeffers [beb486a] [PE-7148] Update Upload coin gated track button to populate initial form data (#13424) KJ [0bc129c] [PE-7121] Add tooltip for coin price in insights section (#13422) KJ [12cbd20] [PE-7196] Fix coin balance loading state (#13420) KJ [3c24888] [PD-488] Fix spacing in the coin details right section (#13423) KJ [20f30bc] Version Packages (#13416) github-actions[bot] [5c7cc68] [PE-7322] Fix comment reply right padding (#13417) KJ [6fea43f] [PE-7325] Fix tip $AUDIO balance large after swap to $AUDIO (#13415) Reed [74098b3] [PE-7288] Update edit coin description field height (#13413) KJ [1f84141] Timeout image loading in case of hanging connections (#13409) Danny [6fd0a97] Add DOM test output on web-test failures (#13383) JD Francis [0fd54bc] [PE-7316] Update artist coin hover card width (#13412) Dylan Jeffers [950757b] [PE-7315] Fix remix contest winners index (#13397) Dylan Jeffers [09d0bbb] [PE-7204] Associate external wallet after swap (#13411) Dylan Jeffers [6173e94] Format tickers for urls and hooks (#13402) KJ [a0125db] Filter out unsupported challenges from notifs (#13408) Reed [48ccd99] Drop photo requirement text (#13407) Dylan Jeffers [23d315d] Fix takeover cta (#13406) KJ [9a0cc8c] css lint fixes (#13405) KJ [f8e35fc] Artist takeover (#13403) KJ [a705fcd] Add banner (#13404) KJ [cb4c07e] Ensure the token mint is set correctly in meteora dbc swaps (#13401) Marcus Pasell [16da7c3] Fix bundlesize check (#13400) Dylan Jeffers [6395893] Revert "[PE-7239] Fix issues due to stale local storage data (#13311)" (#13396) Dylan Jeffers [2b8e0c9] [PE-7312] Update announcement notifs to link from notif data (#13395) KJ [f96f996] Fix user track filter type (#13394) Dylan Jeffers [83bcf85] [PE-7307, PE-7308] Add coin redeem pages (#13390) KJ

Kyle-Shanks requested review from dharit-tan, dylanjeffers and schottra November 7, 2025 22:05

pull-request-size Bot added the size/XL label Nov 7, 2025

dharit-tan reviewed Nov 7, 2025

View reviewed changes

dharit-tan approved these changes Nov 7, 2025

View reviewed changes

dylanjeffers approved these changes Nov 8, 2025

View reviewed changes

Kyle-Shanks added 2 commits November 10, 2025 10:38

Add web and mobile web coin redeem page

5dd8c8b

Update web redeem page and add mobile redeem page, add hooks for clai…

6e274a7

…ming, and connect claim buttons

schottra reviewed Nov 10, 2025

View reviewed changes

Kyle-Shanks force-pushed the kj-Add-web-coin-redeem-page branch from 5221da3 to 6e274a7 Compare November 10, 2025 16:39

small updates

d931156

Kyle-Shanks merged commit 83bcf85 into main Nov 10, 2025
3 of 4 checks passed

Kyle-Shanks deleted the kj-Add-web-coin-redeem-page branch November 10, 2025 16:49

Uh oh!

Conversation

Kyle-Shanks commented Nov 7, 2025

Description

How Has This Been Tested?

Uh oh!

changeset-bot Bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dharit-tan left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot Bot commented Nov 7, 2025 •

edited

Loading