Skip to content

Add error state if jup quote fails - #13344

Merged
dharit-tan merged 3 commits into
mainfrom
rt-jup
Oct 31, 2025
Merged

Add error state if jup quote fails#13344
dharit-tan merged 3 commits into
mainfrom
rt-jup

Conversation

@dharit-tan

@dharit-tan dharit-tan commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Description

We're experiencing intermittent 400's from jupiter quote api, but not surfacing them to the user, so the user could potentially hit continue and submit a bad tx. This PR adds an error state in this case and disables the continue button.

How Has This Been Tested?

https://github.com/user-attachments/assets/d4d77d11-3036-437f-92fa-39038dda65b7
Simulator Screenshot - iPhone 16 Pro - 2025-10-30 at 17 55 39

@changeset-bot

changeset-bot Bot commented Oct 30, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 2d0b454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread packages/web/src/components/buy-sell-modal/BuySellFlow.tsx Outdated
@dharit-tan
dharit-tan merged commit eb8b147 into main Oct 31, 2025
6 of 9 checks passed
@dharit-tan
dharit-tan deleted the rt-jup branch October 31, 2025 02:30
dharit-tan added a commit that referenced this pull request Oct 31, 2025
### Description
We're experiencing intermittent 400's from jupiter quote api, but not
surfacing them to the user, so the user could potentially hit continue
and submit a bad tx. This PR adds an error state in this case and
disables the continue button.

### How Has This Been Tested?


https://github.com/user-attachments/assets/d4d77d11-3036-437f-92fa-39038dda65b7
<img width="1206" height="2622" alt="Simulator Screenshot - iPhone 16
Pro - 2025-10-30 at 17 55 39"
src="https://github.com/user-attachments/assets/af87d941-3fbf-471c-a3d4-e4d93a2455ac"
/>
dharit-tan added a commit that referenced this pull request Oct 31, 2025
### Description
We're experiencing intermittent 400's from jupiter quote api, but not
surfacing them to the user, so the user could potentially hit continue
and submit a bad tx. This PR adds an error state in this case and
disables the continue button.

### How Has This Been Tested?


https://github.com/user-attachments/assets/d4d77d11-3036-437f-92fa-39038dda65b7
<img width="1206" height="2622" alt="Simulator Screenshot - iPhone 16
Pro - 2025-10-30 at 17 55 39"
src="https://github.com/user-attachments/assets/af87d941-3fbf-471c-a3d4-e4d93a2455ac"
/>
audius-infra pushed a commit that referenced this pull request Nov 1, 2025
[98da331] Claim vested coins flow QA (#13335) Reed
[0216cc9] [PE-7255] Add user balance history graph (#13337) Dylan Jeffers
[fb07b7a] [PE-7256|PE-7257] Rework artist coins list & create add cash page (#13341) JD Francis
[20bbd05] Drop donation (#13346) Dylan Jeffers
[c6de169] Fix exclusive tracks section playback (#13348) Dylan Jeffers
[eb8b147] Add error state if jup quote fails (#13344) Reed
[0903d80] Select artist-coin flair fixes (#13345) Dylan Jeffers
[e01065d] [PE-7266] Add coin exclusive tracks to coin page (#13332) Dylan Jeffers
[0aef321] Update FixedDecimal to support scientific notation (#13339) Marcus Pasell
[096aa76] [PE-7232] Fix smart tab behavior for external wallets + fix unauth buy button coins table (#13336) JD Francis
[1e2e0a6] [PE-7252] Always show user's launched coin (#13334) Reed
[da27d25] Version Packages (#13331) github-actions[bot]
[c13483e] Drop rights and covers feature flag (#13324) Dylan Jeffers
[28791a9] Add artist coin flair selector feature (#13317) Farid Salau
[2625849] [PE-7253] Fix web explore page title (#13326) Reed
[c275d11] Fix web lint (#13325) Reed
[46ad234] [PE-7237] Claim vested coins flow (#13307) Reed
[57b5340] Drop ai-attribution (#13321) Dylan Jeffers
[99e2e8c] Drop track replace flag (#13323) Dylan Jeffers
[705381c] [PE-7249] Invalidate artist-coin on buy/sell/swap (#13322) Dylan Jeffers
[87dbc94] [PE-7235] Fix pay with anything token picker (#13316) Dylan Jeffers
[bfadb5b] Revert "Artist coins page size 1000 (#13313)" (#13320) Reed
[452326b] Revert "[PE-7204] Associate wallets on solana /relay calls" (#13314) JD Francis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants