Fix double reaction bug - #13329
Merged
Merged
Conversation
|
dylanjeffers
approved these changes
Oct 28, 2025
| existing_reaction = params.existing_records[EntityType.COMMENT_REACTION.value].get( | ||
| (user_id, comment_id) | ||
| ) | ||
| if existing_reaction and existing_reaction.is_delete: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexing was getting stalled from the previous fix because the primary key would already exist.
This change reverts #13282 and fixes it a different way by moving the check for existing deleted comments to the validation logic, and adding the code to handle that case in the reaction creation logic.
Also adds commands for
audius-cmdand tested locally.NOTE: Re-liking a comment will not trigger a new notification. Made a call that we probably don't want to spam notifs every time it toggles.