Update Binaryen to fix #2810#2811
Merged
CountBleck merged 1 commit intoAssemblyScript:mainfrom Jan 14, 2024
Merged
Conversation
Member
CountBleck
commented
Jan 14, 2024
CountBleck
commented
- I've read the contributing guidelines
- I've added my name and email to the NOTICE file
dcodeIO
reviewed
Jan 14, 2024
dcodeIO
reviewed
Jan 14, 2024
This version of binaryen.js has the requisite 4 GiB max memory change. Fixes AssemblyScript#2810.
Member
|
The global access changes seem interesting, btw. Not sure if Binaryen no longer optimizes these to cache to locals, or undoes what the compiler already does on purpose. If it's the former, then perhaps there are new configuration options (to achieve the same as before), and if it's the latter, we might simplify emitted code. |
Member
Author
|
It looks like (from my limited testing) there's some smarter threshold that isn't "some variable being accessed a bunch of times". I'll try to look into it further. |
Member
Binaryen doesn't optimize simple global access anymore: WebAssembly/binaryen#6087 |
Member
Author
|
@dcodeIO is there any particular reason one might prefer the old behavior? |
Member
Author
|
@dcodeIO Do I have the green light to merge? |
dcodeIO
approved these changes
Jan 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.