Fix to allow only one radio button to be selected - #32
Merged
Conversation
breedloj
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference ticket: https://issues.amazon.com/issues/ECLIPSE-298
During some refactoring, the onWidgetSelection listener of the radio buttons was accidentally removed(representing Positive and Negative sentiments), which allowed both radio buttons to be selected simultaneously.
The PR aims to fix that, which would allow only one radio button to be selected at a time and hence setting the correct selected sentiment state. WidgetListeners for each radio button can be and mostly be different only, so extracting the same out of the common method which creates custom radio buttons.
The changes have been tested on local and working smooth.