Toggle suggestions - #13
Merged
Merged
Conversation
breedloj
reviewed
Sep 16, 2024
dingfeli
force-pushed
the
toggle-suggestions
branch
from
September 17, 2024 16:25
8f4823a to
0b993c5
Compare
breedloj
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Premise
This change enables users to switch between suggestions.
Note that this change does not include a visual component to convey the number of suggestions there are (since that would requires some additional discussions, which would likely take place next week).
The users are permitted to cycle through suggestions under the following circumstance:
Test
Here you can see the toggling in action. I had set the hot key to 'opt + [' and 'opt + ]' for backwards and forwards respectively.
The input sequence for the hotkey, when un-intercepted, produces " and ' respectively.
This is why you see
"being input during the typeahead below, demonstrating that the suggestion toggling is no longer enabled once typeahead has started.Once user has returned to the caret positions prior to any typeahead, the toggling is once again enabled:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.