Skip to content

Fix dropdown menu width not matching button width #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keijokapp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dropdown menu width not matching button width #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions packages/dropdown_button2/lib/src/dropdown_button2.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,8 +949,6 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>> with WidgetsBin
},
);

result = KeyedSubtree(key: _buttonRectKey, child: result);

// When an InputDecoration is provided, use it instead of using an InkWell
// that overflows in some cases (such as showing an errorText) and requires
// additional logic to manage clipping properly.
Expand Down Expand Up @@ -992,12 +990,15 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>> with WidgetsBin
onTap: _enabled && !widget.openWithLongPress ? _handleTap : null,
onLongPress: _enabled && widget.openWithLongPress ? _handleTap : null,
behavior: HitTestBehavior.opaque,
child: InputDecorator(
decoration: effectiveDecoration,
isEmpty: widget._isEmpty,
isFocused: _isFocused,
isHovering: _isHovering,
child: result,
child: KeyedSubtree(
key: _buttonRectKey,
child: InputDecorator(
decoration: effectiveDecoration,
isEmpty: widget._isEmpty,
isFocused: _isFocused,
isHovering: _isHovering,
child: result,
),
),
),
),
Expand All @@ -1013,7 +1014,7 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>> with WidgetsBin
overlayColor: _buttonStyle?.overlayColor,
enableFeedback: false,
borderRadius: _getButtonBorderRadius(context),
child: result,
child: KeyedSubtree(key: _buttonRectKey, child: result),
);
}

Expand Down