Skip to content

json.dump(ensure_ascii=False)#14108

Merged
AUTOMATIC1111 merged 1 commit intodevfrom
json.dump(ensure_ascii=False)
Nov 26, 2023
Merged

json.dump(ensure_ascii=False)#14108
AUTOMATIC1111 merged 1 commit intodevfrom
json.dump(ensure_ascii=False)

Conversation

@w-e-w
Copy link
Copy Markdown
Collaborator

@w-e-w w-e-w commented Nov 26, 2023

Description

json.dump(ensure_ascii=False) for lora metadata config cache.json ui-config config_states
improve readability especially useful for non English users

example lora metadata
from this

{
    "description": "",
    "sd version": "SD1",
    "activation text": "",
    "preferred weight": 0.5,
    "notes": "\u9019\u662f\u500b\u6e2c\u8a66"
}

to this

{
    "description": "",
    "sd version": "SD1",
    "activation text": "",
    "preferred weight": 0.5,
    "notes": "這是個測試"
}

Screenshots/videos:

Checklist:

improve json readability
@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner November 26, 2023 13:11
@AUTOMATIC1111 AUTOMATIC1111 merged commit 500de91 into dev Nov 26, 2023
@AUTOMATIC1111 AUTOMATIC1111 deleted the json.dump(ensure_ascii=False) branch November 26, 2023 13:15
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants