Remove masks and update gmm function in moe.py#4082
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
NuojCheng
requested review from
A9isha,
NicoGrande,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
michelle-yooh,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
|
🤖 Hi @NuojCheng, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @NuojCheng, but I was unable to process your request. Please see the logs for more details. |
NuojCheng
force-pushed
the
chengnuojin-remove-mask
branch
from
ade8434 to
563a28a
Compare
RissyRan
approved these changes
Jun 8, 2026
RissyRan
left a comment
RissyRan
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for clean this up and add one more removal!
khatwanimohit
approved these changes
Jun 8, 2026
Update reference HLO from CI artifact
NuojCheng
force-pushed
the
chengnuojin-remove-mask
branch
from
80f6d4a to
2d109a6
Compare
4 tasks
copybara-service Bot
pushed a commit
that referenced
this pull request
Jun 11, 2026
# Description 1. Refactor `manual_axis_type` conditional specification. - It was previously introduced by [PR#3770](#3770) and [PR#3869](#3869). - It requires tokamax > 0.12.0 (unreleased yet) with [commit](openxla/tokamax@cc374e3) - It is used for gmm shard_map with check_vma=True. This is currently only activated for experimental run (deepseek_batchsplit and use_manual_quantization). Tests won't blocked by dependency. 2. Add unit test for `use_tokamax_gmm=True` for smoke train. Both bf16 and fp8. - Smoke train instead of AOT as blocked by b/489205940 - Run in g3 only to save github CI/CD time 3. Reset `group offset` to None: [PR#4082](#4082) added `group_offset` to `tokamax.ragged_dot` and `tokamax.ragged_dot_general`. However, `group_offset` is not yet supported by tokamax: - see [tokamax code](https://github.com/openxla/tokamax/blob/cdde910bf925d834c0c9e6cee5a488095f0381d4/tokamax/_src/ops/ragged_dot/api.py#L177-L178) - the added unit test meet [error](http://shortn/_oy55Dkh22N) # Tests unit test `tokamax_gmm_test` # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). PiperOrigin-RevId: 930601487
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherrypicks proposed changes from @RissyRan in here, and do following things
group_offsetinputFIXES: b/519220305
Tests
Xprof
Get better ~9% better result by removing broadcast_select and changes in Fix ragged gather reduce to offload two sparse cores #4077 .
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.