Skip to content

bench: refactor random number generation in number/int32/base/mul#11494

Merged
kgryte merged 2 commits intostdlib-js:developfrom
impawstarlight:bench/imul32
Apr 17, 2026
Merged

bench: refactor random number generation in number/int32/base/mul#11494
kgryte merged 2 commits intostdlib-js:developfrom
impawstarlight:bench/imul32

Conversation

@impawstarlight
Copy link
Copy Markdown
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for number/int32/base/mul
  • Moves the random number generation outside the benchmarking loops
  • Replaces minstd() usage with discreteUniform()
  • Replaces isnan() checks with range based checks for integer focused code path

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@impawstarlight impawstarlight requested a review from a team April 16, 2026 21:24
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Apr 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Apr 16, 2026

Coverage Report

Package Statements Branches Functions Lines
number/int32/base/mul $\color{green}211/211$
$\color{green}+0.00%$
$\color{red}6/7$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}211/211$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 17, 2026
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning up, @impawstarlight!

@kgryte kgryte merged commit 99dbca0 into stdlib-js:develop Apr 17, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants