Skip to content

Config fixes#75

Merged
hcsa73 merged 13 commits into
mainfrom
hs/fix/testing
Feb 8, 2024
Merged

Config fixes#75
hcsa73 merged 13 commits into
mainfrom
hs/fix/testing

Conversation

@hcsa73
Copy link
Copy Markdown
Contributor

@hcsa73 hcsa73 commented Feb 8, 2024

  • Add --session-time-limit to config unset
  • Change config unset behavior to set as the default, instead of setting to "" (so it reverts config set)
  • Fix config list not showing bool values
  • Change --async default to bool type (so its value in the config file is always bool -- before it was bool or string)
  • Rewrite descriptions. Most notably,
    • Move the config logic with env vars from config set to config list
    • Move flag details from examples to the flag descriptions

Comment thread internal/cmd/config/list/list.go
Comment thread internal/cmd/config/set/set.go Outdated
Comment thread internal/cmd/config/set/set.go Outdated
Comment thread internal/cmd/config/unset/unset.go Outdated
@hcsa73 hcsa73 enabled auto-merge (squash) February 8, 2024 16:50
@hcsa73 hcsa73 merged commit cefddda into main Feb 8, 2024
@hcsa73 hcsa73 deleted the hs/fix/testing branch February 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants