From 13f8b9d418809d862137f5807384d6a08523f37e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Palet?= <joao.palet@freiheit.com>
Date: Fri, 22 Mar 2024 12:32:26 +0000
Subject: [PATCH] Extend unit tests of updates using CIDRSliceFlag

---
 internal/cmd/mariadb/instance/update/update_test.go   | 11 +++++++++++
 .../cmd/mongodbflex/instance/update/update_test.go    | 11 +++++++++++
 .../cmd/opensearch/instance/update/update_test.go     | 11 +++++++++++
 .../cmd/postgresflex/instance/update/update_test.go   | 11 +++++++++++
 internal/cmd/rabbitmq/instance/update/update_test.go  | 11 +++++++++++
 internal/cmd/redis/instance/update/update_test.go     | 11 +++++++++++
 6 files changed, 66 insertions(+)

diff --git a/internal/cmd/mariadb/instance/update/update_test.go b/internal/cmd/mariadb/instance/update/update_test.go
index 19a1b0ea1..362bf4447 100644
--- a/internal/cmd/mariadb/instance/update/update_test.go
+++ b/internal/cmd/mariadb/instance/update/update_test.go
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
 			flagValues:  fixtureFlagValues(),
 			isValid:     false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, sgwAclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.SgwAcl = nil
+			}),
+		},
 		{
 			description:  "repeated acl flags",
 			argValues:    fixtureArgValues(),
diff --git a/internal/cmd/mongodbflex/instance/update/update_test.go b/internal/cmd/mongodbflex/instance/update/update_test.go
index 3995d1acf..9390d83ff 100644
--- a/internal/cmd/mongodbflex/instance/update/update_test.go
+++ b/internal/cmd/mongodbflex/instance/update/update_test.go
@@ -251,6 +251,17 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureStandardFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, aclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureStandardInputModel(func(model *inputModel) {
+				model.ACL = nil
+			}),
+		},
 		{
 			description: "repeated acl flags",
 			argValues:   fixtureArgValues(),
diff --git a/internal/cmd/opensearch/instance/update/update_test.go b/internal/cmd/opensearch/instance/update/update_test.go
index 5141e905e..7623b7dde 100644
--- a/internal/cmd/opensearch/instance/update/update_test.go
+++ b/internal/cmd/opensearch/instance/update/update_test.go
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
 			flagValues:  fixtureFlagValues(),
 			isValid:     false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, sgwAclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.SgwAcl = nil
+			}),
+		},
 		{
 			description:  "repeated acl flags",
 			argValues:    fixtureArgValues(),
diff --git a/internal/cmd/postgresflex/instance/update/update_test.go b/internal/cmd/postgresflex/instance/update/update_test.go
index 7d83737c5..190823939 100644
--- a/internal/cmd/postgresflex/instance/update/update_test.go
+++ b/internal/cmd/postgresflex/instance/update/update_test.go
@@ -251,6 +251,17 @@ func TestParseInput(t *testing.T) {
 			}),
 			isValid: false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureStandardFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, aclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureStandardInputModel(func(model *inputModel) {
+				model.ACL = nil
+			}),
+		},
 		{
 			description: "repeated acl flags",
 			argValues:   fixtureArgValues(),
diff --git a/internal/cmd/rabbitmq/instance/update/update_test.go b/internal/cmd/rabbitmq/instance/update/update_test.go
index a617cb4c0..fe62bbd43 100644
--- a/internal/cmd/rabbitmq/instance/update/update_test.go
+++ b/internal/cmd/rabbitmq/instance/update/update_test.go
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
 			flagValues:  fixtureFlagValues(),
 			isValid:     false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, sgwAclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.SgwAcl = nil
+			}),
+		},
 		{
 			description:  "repeated acl flags",
 			argValues:    fixtureArgValues(),
diff --git a/internal/cmd/redis/instance/update/update_test.go b/internal/cmd/redis/instance/update/update_test.go
index e31a87b8e..73c49e3f1 100644
--- a/internal/cmd/redis/instance/update/update_test.go
+++ b/internal/cmd/redis/instance/update/update_test.go
@@ -226,6 +226,17 @@ func TestParseInput(t *testing.T) {
 			flagValues:  fixtureFlagValues(),
 			isValid:     false,
 		},
+		{
+			description: "no acl flag",
+			argValues:   fixtureArgValues(),
+			flagValues: fixtureFlagValues(func(flagValues map[string]string) {
+				delete(flagValues, sgwAclFlag)
+			}),
+			isValid: true,
+			expectedModel: fixtureInputModel(func(model *inputModel) {
+				model.SgwAcl = nil
+			}),
+		},
 		{
 			description:  "repeated acl flags",
 			argValues:    fixtureArgValues(),