Skip to content

Commit bcde164

Browse files
author
João Palet
committed
Fix tests
1 parent 392762f commit bcde164

2 files changed

Lines changed: 18 additions & 29 deletions

File tree

internal/cmd/beta/sqlserverflex/user/create/create.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ const (
2525
roleFlag = "role"
2626
)
2727

28-
var (
29-
rolesDefault = []string{"read"}
30-
)
31-
3228
type inputModel struct {
3329
*globalflags.GlobalFlagModel
3430

internal/cmd/beta/sqlserverflex/user/create/create_test.go

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,26 @@ func TestParseInput(t *testing.T) {
8888
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
8989
delete(flagValues, usernameFlag)
9090
}),
91+
isValid: false,
92+
},
93+
{
94+
description: "no database specified",
95+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
96+
delete(flagValues, databaseFlag)
97+
}),
9198
isValid: true,
9299
expectedModel: fixtureInputModel(func(model *inputModel) {
93-
model.Username = nil
100+
model.Database = nil
101+
}),
102+
},
103+
{
104+
description: "no roles specified",
105+
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
106+
delete(flagValues, roleFlag)
107+
}),
108+
isValid: true,
109+
expectedModel: fixtureInputModel(func(model *inputModel) {
110+
model.Roles = nil
94111
}),
95112
},
96113
{
@@ -133,30 +150,6 @@ func TestParseInput(t *testing.T) {
133150
}),
134151
isValid: false,
135152
},
136-
{
137-
description: "database missing",
138-
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
139-
delete(flagValues, databaseFlag)
140-
}),
141-
isValid: false,
142-
},
143-
{
144-
description: "roles missing",
145-
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
146-
delete(flagValues, roleFlag)
147-
}),
148-
isValid: true,
149-
expectedModel: fixtureInputModel(func(model *inputModel) {
150-
model.Roles = &rolesDefault
151-
}),
152-
},
153-
{
154-
description: "invalid role",
155-
flagValues: fixtureFlagValues(func(flagValues map[string]string) {
156-
flagValues[roleFlag] = "invalid-role"
157-
}),
158-
isValid: false,
159-
},
160153
}
161154

162155
for _, tt := range tests {

0 commit comments

Comments
 (0)