Onboard Argus (instance): create command and utils (#133)

* Onboard Argus instance: create command init

* create command: complete functionality and start testing

* create command: added testing for utils

* update utils error message

* Add custom Argus error and fix create command testing

* fix error formatting in utils

* fix error formatting

Author: DiogoFerrao

docs/stackit_argus.md

@@ -28,5 +28,6 @@ stackit argus [flags]
 ### SEE ALSO
 
 * [stackit](./stackit.md)	 - Manage STACKIT resources using the command line
+* [stackit argus instance](./stackit_argus_instance.md)	 - Provides functionality for Argus instances
 * [stackit argus plans](./stackit_argus_plans.md)	 - Lists all Argus service plans
 

docs/stackit_argus_instance.md

@@ -0,0 +1,32 @@
+## stackit argus instance
+
+Provides functionality for Argus instances
+
+### Synopsis
+
+Provides functionality for Argus instances.
+
+```
+stackit argus instance [flags]
+```
+
+### Options
+
+```
+  -h, --help   Help for "stackit argus instance"
+```
+
+### Options inherited from parent commands
+
+```
+  -y, --assume-yes             If set, skips all confirmation prompts
+      --async                  If set, runs the command asynchronously
+  -o, --output-format string   Output format, one of ["json" "pretty"]
+  -p, --project-id string      Project ID
+```
+
+### SEE ALSO
+
+* [stackit argus](./stackit_argus.md)	 - Provides functionality for Argus
+* [stackit argus instance create](./stackit_argus_instance_create.md)	 - Creates an Argus instance
+

docs/stackit_argus_instance_create.md

@@ -0,0 +1,44 @@
+## stackit argus instance create
+
+Creates an Argus instance
+
+### Synopsis
+
+Creates an Argus instance.
+
+```
+stackit argus instance create [flags]
+```
+
+### Examples
+
+```
+  Create an Argus instance with name "my-instance" and specify plan by name
+  $ stackit argus instance create --name my-instance --plan-name Monitoring-Starter-EU01
+
+  Create an Argus instance with name "my-instance" and specify plan by ID
+  $ stackit argus instance create --name my-instance --plan-id xxx
+```
+
+### Options
+
+```
+  -h, --help               Help for "stackit argus instance create"
+  -n, --name string        Instance name
+      --plan-id string     Plan ID
+      --plan-name string   Plan name
+```
+
+### Options inherited from parent commands
+
+```
+  -y, --assume-yes             If set, skips all confirmation prompts
+      --async                  If set, runs the command asynchronously
+  -o, --output-format string   Output format, one of ["json" "pretty"]
+  -p, --project-id string      Project ID
+```
+
+### SEE ALSO
+
+* [stackit argus instance](./stackit_argus_instance.md)	 - Provides functionality for Argus instances
+

internal/cmd/argus/argus.go

@@ -1,6 +1,7 @@
 package argus
 
 import (
+	"github.com/stackitcloud/stackit-cli/internal/cmd/argus/instance"
 	"github.com/stackitcloud/stackit-cli/internal/cmd/argus/plans"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
@@ -22,4 +23,5 @@ func NewCmd() *cobra.Command {
 
 func addSubcommands(cmd *cobra.Command) {
 	cmd.AddCommand(plans.NewCmd())
+	cmd.AddCommand(instance.NewCmd())
 }

internal/cmd/argus/instance/create/create.go

@@ -0,0 +1,191 @@
+package create
+
+import (
+	"context"
+	"errors"
+	"fmt"
+
+	"github.com/stackitcloud/stackit-cli/internal/pkg/args"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/confirm"
+	cliErr "github.com/stackitcloud/stackit-cli/internal/pkg/errors"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/examples"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/flags"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/projectname"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/services/argus/client"
+	argusUtils "github.com/stackitcloud/stackit-cli/internal/pkg/services/argus/utils"
+	"github.com/stackitcloud/stackit-cli/internal/pkg/spinner"
+
+	"github.com/spf13/cobra"
+	"github.com/stackitcloud/stackit-sdk-go/services/argus"
+	"github.com/stackitcloud/stackit-sdk-go/services/argus/wait"
+)
+
+const (
+	instanceNameFlag = "name"
+	planIdFlag       = "plan-id"
+	planNameFlag     = "plan-name"
+)
+
+type inputModel struct {
+	*globalflags.GlobalFlagModel
+	PlanName string
+
+	InstanceName *string
+	PlanId       *string
+}
+
+func NewCmd() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "create",
+		Short: "Creates an Argus instance",
+		Long:  "Creates an Argus instance.",
+		Args:  args.NoArgs,
+		Example: examples.Build(
+			examples.NewExample(
+				`Create an Argus instance with name "my-instance" and specify plan by name`,
+				"$ stackit argus instance create --name my-instance --plan-name Monitoring-Starter-EU01"),
+			examples.NewExample(
+				`Create an Argus instance with name "my-instance" and specify plan by ID`,
+				"$ stackit argus instance create --name my-instance --plan-id xxx"),
+		),
+		RunE: func(cmd *cobra.Command, args []string) error {
+			ctx := context.Background()
+			model, err := parseInput(cmd)
+			if err != nil {
+				return err
+			}
+
+			// Configure API client
+			apiClient, err := client.ConfigureClient(cmd)
+			if err != nil {
+				return err
+			}
+
+			projectLabel, err := projectname.GetProjectName(ctx, cmd)
+			if err != nil {
+				projectLabel = model.ProjectId
+			}
+
+			if !model.AssumeYes {
+				prompt := fmt.Sprintf("Are you sure you want to create an Argus instance for project %q?", projectLabel)
+				err = confirm.PromptForConfirmation(cmd, prompt)
+				if err != nil {
+					return err
+				}
+			}
+
+			// Call API
+			req, err := buildRequest(ctx, model, apiClient)
+			if err != nil {
+				var argusInvalidPlanError *cliErr.ArgusInvalidPlanError
+				if !errors.As(err, &argusInvalidPlanError) {
+					return fmt.Errorf("build Argus instance creation request: %w", err)
+				}
+				return err
+			}
+			resp, err := req.Execute()
+			if err != nil {
+				return fmt.Errorf("create Argus instance: %w", err)
+			}
+			instanceId := *resp.InstanceId
+
+			// Wait for async operation, if async mode not enabled
+			if !model.Async {
+				s := spinner.New(cmd)
+				s.Start("Creating instance")
+				_, err = wait.CreateInstanceWaitHandler(ctx, apiClient, instanceId, model.ProjectId).WaitWithContext(ctx)
+				if err != nil {
+					return fmt.Errorf("wait for Argus instance creation: %w", err)
+				}
+				s.Stop()
+			}
+
+			operationState := "Created"
+			if model.Async {
+				operationState = "Triggered creation of"
+			}
+			cmd.Printf("%s instance for project %q. Instance ID: %s\n", operationState, projectLabel, instanceId)
+			return nil
+		},
+	}
+	configureFlags(cmd)
+	return cmd
+}
+
+func configureFlags(cmd *cobra.Command) {
+	cmd.Flags().StringP(instanceNameFlag, "n", "", "Instance name")
+	cmd.Flags().Var(flags.UUIDFlag(), planIdFlag, "Plan ID")
+	cmd.Flags().String(planNameFlag, "", "Plan name")
+
+	err := flags.MarkFlagsRequired(cmd, instanceNameFlag)
+	cobra.CheckErr(err)
+}
+
+func parseInput(cmd *cobra.Command) (*inputModel, error) {
+	globalFlags := globalflags.Parse(cmd)
+	if globalFlags.ProjectId == "" {
+		return nil, &cliErr.ProjectIdError{}
+	}
+
+	planId := flags.FlagToStringPointer(cmd, planIdFlag)
+	planName := flags.FlagToStringValue(cmd, planNameFlag)
+
+	if planId == nil && (planName == "") {
+		return nil, &cliErr.ArgusInputPlanError{
+			Cmd: cmd,
+		}
+	}
+	if planId != nil && (planName != "") {
+		return nil, &cliErr.ArgusInputPlanError{
+			Cmd: cmd,
+		}
+	}
+
+	return &inputModel{
+		GlobalFlagModel: globalFlags,
+		InstanceName:    flags.FlagToStringPointer(cmd, instanceNameFlag),
+		PlanId:          planId,
+		PlanName:        planName,
+	}, nil
+}
+
+type argusClient interface {
+	CreateInstance(ctx context.Context, projectId string) argus.ApiCreateInstanceRequest
+	ListPlansExecute(ctx context.Context, projectId string) (*argus.PlansResponse, error)
+}
+
+func buildRequest(ctx context.Context, model *inputModel, apiClient argusClient) (argus.ApiCreateInstanceRequest, error) {
+	req := apiClient.CreateInstance(ctx, model.ProjectId)
+
+	var planId *string
+	var err error
+
+	plans, err := apiClient.ListPlansExecute(ctx, model.ProjectId)
+	if err != nil {
+		return req, fmt.Errorf("get Argus plans: %w", err)
+	}
+
+	if model.PlanId == nil {
+		planId, err = argusUtils.LoadPlanId(model.PlanName, plans)
+		if err != nil {
+			var argusInvalidPlanError *cliErr.ArgusInvalidPlanError
+			if !errors.As(err, &argusInvalidPlanError) {
+				return req, fmt.Errorf("load plan ID: %w", err)
+			}
+			return req, err
+		}
+	} else {
+		err := argusUtils.ValidatePlanId(*model.PlanId, plans)
+		if err != nil {
+			return req, err
+		}
+		planId = model.PlanId
+	}
+
+	req = req.CreateInstancePayload(argus.CreateInstancePayload{
+		Name:   model.InstanceName,
+		PlanId: planId,
+	})
+	return req, nil
+}