Skip to content

When installing a release, install operators in parallel#202

Merged
nightkr merged 3 commits into
mainfrom
feature/release-parallel-install
Feb 8, 2024
Merged

When installing a release, install operators in parallel#202
nightkr merged 3 commits into
mainfrom
feature/release-parallel-install

Conversation

@nightkr

@nightkr nightkr commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

Description

stackablectl release install is sloooow, partially because we wait for each operator to download/start before we start installing the next one.

We might as well try to install them in parallel.

Ideally each Helm operation would run on a background task (via tokio's spawn_blocking), but that's a much larger refactoring than this PR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Helm chart can be installed and deployed operator works
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team February 7, 2024 11:41

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment thread rust/stackablectl/CHANGELOG.md Outdated
@nightkr nightkr requested a review from Techassi February 8, 2024 14:34
@nightkr nightkr added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit ccb9ba3 Feb 8, 2024
@nightkr nightkr deleted the feature/release-parallel-install branch February 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants