fix(careers): harden Ashby parsing and filter edge cases from review

- validate jobUrl as http(s) only; drop postings with unsafe URLs
- validate postings individually so one bad row can't empty the board
- namespace the all-filter sentinel to avoid colliding with real values
- dedupe the job metadata line (fixes duplicate React keys / Remote·Remote)
- parse filters server-side so deep-linked views don't flash unfiltered

Author: waleedlatif1

apps/sim/app/(landing)/careers/careers.tsx

@@ -1,12 +1,19 @@
 import { Suspense } from 'react'
+import type { SearchParams } from 'nuqs/server'
 import { getAshbyJobs } from '@/lib/ashby/jobs'
 import {
+  filterPostings,
   groupByDepartment,
   JobBoard,
   JobGroups,
 } from '@/app/(landing)/careers/components/job-board'
+import { careersSearchParamsCache } from '@/app/(landing)/careers/search-params'
 import { TrustedBy } from '@/app/(landing)/components/trusted-by'
 
+interface CareersProps {
+  searchParams: Promise<SearchParams>
+}
+
 /**
  * The careers page — a mission-led hero above the live open-roles board. Roles
  * are pulled from Sim's public Ashby job board at build/revalidate time
@@ -21,12 +28,15 @@ import { TrustedBy } from '@/app/(landing)/components/trusted-by'
  * citation (landing CLAUDE.md → GEO); the roles section owns its own `<h2>`.
  *
  * Because {@link JobBoard} reads the URL via nuqs (`useSearchParams`), it sits under
- * a `<Suspense>` boundary whose fallback is the same list rendered statically
- * ({@link JobGroups}) — so the roles are present in the prerendered HTML and the
- * filter bar simply pops in on hydration, never flashing an empty frame.
+ * a `<Suspense>` boundary. The page parses the same `?team=`/`?location=` query on
+ * the server ({@link careersSearchParamsCache}) and pre-filters the fallback to
+ * match, so a deep-linked filter renders the correct roles server-side — the list
+ * never flashes unfiltered before the client board hydrates.
  */
-export default async function Careers() {
+export default async function Careers({ searchParams }: CareersProps) {
+  const { team, location } = await careersSearchParamsCache.parse(searchParams)
   const postings = await getAshbyJobs()
+  const fallbackGroups = groupByDepartment(filterPostings(postings, team, location))
 
   return (
     <main id='main-content'>
@@ -67,7 +77,7 @@ export default async function Careers() {
           Open roles
         </h2>
 
-        <Suspense fallback={<JobGroups groups={groupByDepartment(postings)} />}>
+        <Suspense fallback={<JobGroups groups={fallbackGroups} />}>
           <JobBoard postings={postings} />
         </Suspense>
 

apps/sim/app/(landing)/careers/components/job-board/index.ts

@@ -1,2 +1,2 @@
 export { JobBoard } from './job-board'
-export { groupByDepartment, JobGroups } from './job-groups'
+export { filterPostings, groupByDepartment, JobGroups } from './job-groups'

apps/sim/app/(landing)/careers/components/job-board/job-board.tsx

@@ -4,6 +4,7 @@ import { ChipSelect, type ChipSelectOption } from '@sim/emcn'
 import { useQueryStates } from 'nuqs'
 import type { CareerPosting } from '@/lib/ashby/jobs'
 import {
+  filterPostings,
   groupByDepartment,
   JobGroups,
 } from '@/app/(landing)/careers/components/job-board/job-groups'
@@ -49,13 +50,7 @@ export function JobBoard({ postings }: JobBoardProps) {
     uniqueSorted(postings.map((p) => p.location).filter(Boolean)),
     'All locations'
   )
-  const groups = groupByDepartment(
-    postings.filter(
-      (p) =>
-        (team === ALL_FILTER_VALUE || p.department === team) &&
-        (location === ALL_FILTER_VALUE || p.location === location)
-    )
-  )
+  const groups = groupByDepartment(filterPostings(postings, team, location))
 
   return (
     <div className='flex flex-col gap-10'>

apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx

@@ -1,12 +1,30 @@
 import { cn } from '@sim/emcn'
 import { ArrowRight } from '@sim/emcn/icons'
 import type { CareerPosting } from '@/lib/ashby/jobs'
+import { ALL_FILTER_VALUE } from '@/app/(landing)/careers/search-params'
 
 export interface DepartmentGroup {
   department: string
   postings: CareerPosting[]
 }
 
+/**
+ * Narrows postings to a selected Team and Location, treating {@link ALL_FILTER_VALUE}
+ * as "any". Shared by the server-rendered fallback and the client board so a
+ * deep-linked filter resolves to the exact same set on both sides.
+ */
+export function filterPostings(
+  postings: CareerPosting[],
+  team: string,
+  location: string
+): CareerPosting[] {
+  return postings.filter(
+    (posting) =>
+      (team === ALL_FILTER_VALUE || posting.department === team) &&
+      (location === ALL_FILTER_VALUE || posting.location === location)
+  )
+}
+
 /**
  * Buckets postings by department, preserving their incoming order (the fetcher
  * pre-sorts by department then title). Shared by the interactive board and its
@@ -74,8 +92,18 @@ interface JobRowProps {
  * tints the row and advances the arrow.
  */
 function JobRow({ posting }: JobRowProps) {
-  const meta = [posting.location, posting.employmentType, posting.workplaceType].filter(Boolean)
-  if (posting.compensationSummary) meta.push(posting.compensationSummary)
+  // De-duplicate: a remote posting normalizes both location and workplaceType to
+  // "Remote", which would otherwise render "Remote · Remote" and collide as keys.
+  const meta = Array.from(
+    new Set(
+      [
+        posting.location,
+        posting.employmentType,
+        posting.workplaceType,
+        posting.compensationSummary,
+      ].filter((value): value is string => Boolean(value))
+    )
+  )
 
   return (
     <a

apps/sim/app/(landing)/careers/page.tsx

@@ -1,3 +1,4 @@
+import type { SearchParams } from 'nuqs/server'
 import { buildLandingMetadata } from '@/lib/landing/seo'
 import Careers from '@/app/(landing)/careers/careers'
 
@@ -11,6 +12,6 @@ export const metadata = buildLandingMetadata({
   keywords: 'Sim careers, Sim jobs, AI workspace jobs, AI agent engineering jobs, open source jobs',
 })
 
-export default function Page() {
-  return <Careers />
+export default function Page({ searchParams }: { searchParams: Promise<SearchParams> }) {
+  return <Careers searchParams={searchParams} />
 }

apps/sim/app/(landing)/careers/search-params.ts

@@ -1,16 +1,18 @@
-import { parseAsString } from 'nuqs/server'
+import { createSearchParamsCache, parseAsString } from 'nuqs/server'
 
-/** Sentinel value for an inactive filter — matches every posting. */
-export const ALL_FILTER_VALUE = 'all'
+/**
+ * Sentinel value for an inactive filter — matches every posting. Namespaced with
+ * underscores so it can never collide with a real Ashby department or location
+ * value (e.g. a team literally named "all").
+ */
+export const ALL_FILTER_VALUE = '__all__'
 
 /**
  * Co-located, typed URL query params for the careers job board's Team and
  * Location filters. Shareable, deep-linkable view-state over an already-rendered
  * list, so it lives in the URL (nuqs) — never in a store. The values are dynamic
  * (departments/locations come from the live board), so plain string parsers with
- * an `all` default rather than a fixed literal set. Imported by the client board
- * (`useQueryStates`); the page renders every posting statically and filters on
- * the client, so no server-side cache is needed.
+ * an `all` sentinel default rather than a fixed literal set.
  */
 export const careersParsers = {
   team: parseAsString.withDefault(ALL_FILTER_VALUE),
@@ -23,3 +25,11 @@ export const careersUrlKeys = {
   shallow: true,
   clearOnDefault: true,
 } as const
+
+/**
+ * Server-side reader for the same parser map. The page parses the request's
+ * query with this so the statically-rendered fallback is filtered to match a
+ * deep-linked `?team=`/`?location=` URL — the roles never flash unfiltered before
+ * the client board hydrates.
+ */
+export const careersSearchParamsCache = createSearchParamsCache(careersParsers)

apps/sim/lib/ashby/jobs.ts

@@ -15,6 +15,17 @@ const ASHBY_JOB_BOARD_URL = `https://api.ashbyhq.com/posting-api/job-board/${ASH
 /** Revalidate the board hourly, shared across every render (build/revalidate-time cache). */
 const REVALIDATE_SECONDS = 3600
 
+/**
+ * An `http(s)`-only URL. `z.string().url()` alone accepts `javascript:`/`data:`
+ * (both parse as valid URLs), which would render as a live link, so the scheme is
+ * pinned explicitly — a posting whose `jobUrl` fails this is dropped rather than
+ * published as a clickable Apply link.
+ */
+const httpUrlSchema = z
+  .string()
+  .url()
+  .refine((value) => /^https?:\/\//i.test(value), 'Only http(s) URLs are allowed')
+
 /**
  * Tolerant schema for a single Ashby posting. The public board omits several
  * fields depending on the posting, so everything beyond the identity/title is
@@ -32,7 +43,7 @@ const ashbyPostingSchema = z
     isListed: z.boolean().nullish(),
     isRemote: z.boolean().nullish(),
     publishedAt: z.string().nullish(),
-    jobUrl: z.string(),
+    jobUrl: httpUrlSchema,
     applyUrl: z.string().nullish(),
     shouldDisplayCompensationOnJobPostings: z.boolean().nullish(),
     compensation: z
@@ -43,9 +54,14 @@ const ashbyPostingSchema = z
   })
   .passthrough()
 
+/**
+ * The board envelope validates loosely — each posting is validated individually
+ * in {@link getAshbyJobs} so a single malformed row is skipped rather than
+ * emptying the entire board.
+ */
 const ashbyJobBoardSchema = z.object({
   apiVersion: z.string().nullish(),
-  jobs: z.array(ashbyPostingSchema),
+  jobs: z.array(z.unknown()),
 })
 
 /** Human-friendly labels for Ashby's enum-ish string fields. */
@@ -101,16 +117,25 @@ export async function getAshbyJobs(): Promise<CareerPosting[]> {
       return []
     }
 
-    const parsed = ashbyJobBoardSchema.safeParse(await response.json())
-    if (!parsed.success) {
-      logger.warn('Ashby job board response failed validation', { issues: parsed.error.issues })
+    const envelope = ashbyJobBoardSchema.safeParse(await response.json())
+    if (!envelope.success) {
+      logger.warn('Ashby job board response failed validation', { issues: envelope.error.issues })
       return []
     }
 
-    return parsed.data.jobs
-      .filter((job) => job.isListed !== false)
-      .map(normalizePosting)
-      .sort(comparePostings)
+    const postings: CareerPosting[] = []
+    for (const raw of envelope.data.jobs) {
+      const parsed = ashbyPostingSchema.safeParse(raw)
+      if (!parsed.success) {
+        // Skip the offending posting rather than emptying the whole board.
+        logger.warn('Skipping malformed Ashby posting', { issues: parsed.error.issues })
+        continue
+      }
+      if (parsed.data.isListed === false) continue
+      postings.push(normalizePosting(parsed.data))
+    }
+
+    return postings.sort(comparePostings)
   } catch (error) {
     logger.warn('Ashby job board request threw', { error })
     return []