Skip to content

Removes duplicated inclusion of Rake::DSL#254

Merged
yuki24 merged 1 commit into
ruby:masterfrom
grzuy:remove_dup_inclusion
Feb 22, 2018
Merged

Removes duplicated inclusion of Rake::DSL#254
yuki24 merged 1 commit into
ruby:masterfrom
grzuy:remove_dup_inclusion

Conversation

@grzuy

@grzuy grzuy commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

Rake::DSL is already included in Rake::TestCase

@grzuy

grzuy commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

Apparently test build failed only for ruby 2.1, because bundle install command was installing rdoc 5.x previously for all builds, but installed rdoc 6.x for the first time with this PR (despite rdoc 6.x released 1 2 months ago), which is no longer compatible with ruby 2.1

Fetching rdoc 6.0.1
Installing rdoc 6.0.1
Gem::RuntimeRequirementNotMetError: rdoc requires Ruby version >= 2.2.2. The
current ruby version is 2.1.0.
An error occurred while installing rdoc (6.0.1), and Bundler cannot continue.
Make sure that `gem install rdoc -v '6.0.1'` succeeds before bundling.

@grzuy

grzuy commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

Reported issue here #255

@hsbt

hsbt commented Feb 22, 2018

Copy link
Copy Markdown
Member

@gazay Can you rebase from master?

Rake::DSL is already included in Rake::TestCase
@grzuy grzuy force-pushed the remove_dup_inclusion branch from 99ff0bf to b86a13b Compare February 22, 2018 12:30
@grzuy

grzuy commented Feb 22, 2018

Copy link
Copy Markdown
Contributor Author

@hsbt Rebased

@yuki24

yuki24 commented Feb 22, 2018

Copy link
Copy Markdown
Member

I'm merging this PR since this seems like a safe change. Thanks @grzuy!

@yuki24 yuki24 merged commit 266a1d4 into ruby:master Feb 22, 2018
@grzuy

grzuy commented Feb 22, 2018

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants