From 1eb1a54072d48cf56311b32802fad027b9801b7f Mon Sep 17 00:00:00 2001 From: Adam Wright Date: Fri, 18 Sep 2026 03:17:14 +0000 Subject: [PATCH 1/2] docs(curators): bring both documents up to today's work `CURATOR-REPORT.md` said the keyboard-reachable controls were "Species and Interactors". That label went back to **Overlay** today (#228) -- it and its position were decided at EBI -- so the document was describing a control that no longer exists under that name. It also claimed 635 shapes come out of R-HSA-109606's PowerPoint export. Re-measured today: **974**, counted from `ppt/slides/slide1.xml`, with zero pictures and no embedded media. The claim the curators were testing -- that it is shapes rather than one picture -- holds; the figure was stale (#167). Added, all of them things a curator will meet: - the count beside each resource now follows the pathway on screen, and why the old numbers were plausible rather than obviously wrong - a selection survives opening a pathway from inside the diagram; the flag was never the problem - illustration downloads work again, **with the caveat that the fix is a cache on this machine** -- so an illustration that still fails is a gap in what is cached, not a fault in the site (#230) - Perturb offers something: its catalogue was never wired up here, so the button appeared and did nothing. Eleven pathways now - if you leave the email box empty when asking for analysis reports, the reports are still made and no mail is sent, with nothing saying so (#238, #168) `RELEASE-TESTING.md` gains the two rows today's fixes are covered by, including why the count is a unit test: a browser test of it passed with and without the fix, which is worse than no test. Co-Authored-By: Claude Opus 5 --- CURATOR-REPORT.md | 34 ++++++++++++++++++++++++++++++++-- RELEASE-TESTING.md | 26 ++++++++++++++------------ 2 files changed, 46 insertions(+), 14 deletions(-) diff --git a/CURATOR-REPORT.md b/CURATOR-REPORT.md index 756d24dc5..bea428a19 100644 --- a/CURATOR-REPORT.md +++ b/CURATOR-REPORT.md @@ -26,7 +26,7 @@ Last updated: 2026-08-22 | [#143](https://github.com/reactome/WebsiteAngular/issues/143) | Same as above, specifically while navigating between pathways with a flag active | As above | | [#154](https://github.com/reactome/WebsiteAngular/issues/154) | Right-click a complex or set after running an analysis: components are listed and the ones in your data are marked | Closed on the basis that the right-click panel delivers this. **Reopen if "within a diagram" meant drawing components as nodes inside the canvas** — that is a much larger piece, and the old GWT browser does not do it either | | [#81](https://github.com/reactome/WebsiteAngular/issues/81) | Community → Events: confirm every attachment you expect is present | All 5 "Poster" links on the page resolve, but if a specific event is missing an attachment we have not spotted it | -| **PowerPoint** | Download a diagram as **PPTX** and open it in real PowerPoint. Every compartment, connector, entity and sub-pathway tint should be its own shape you can select and move, with no conversion step | **We cannot test the opening — there is no PowerPoint on the build machine.** The package is checked structurally, its element order matches production's own file, and 635 shapes come out of R-HSA-109606; "opens in PowerPoint" is still a different claim | +| **PowerPoint** | Download a diagram as **PPTX** and open it in real PowerPoint. Every compartment, connector, entity and sub-pathway tint should be its own shape you can select and move, with no conversion step | **We cannot test the opening — there is no PowerPoint on the build machine.** The package is checked structurally, its element order matches production's own file, and 974 shapes come out of R-HSA-109606; "opens in PowerPoint" is still a different claim | | **GIF** | Download a diagram as **GIF** with an expression analysis active. It should animate one frame per sample and look like the current site | New: it used to come from the old Java exporter, which is why it looked like the old diagrams. Also tell us whether ~1 MB for four samples is acceptable, and whether 1 second per sample is the right pace | | [#141](https://github.com/reactome/WebsiteAngular/issues/141) | **Animated SVG**: open the downloaded file in a browser or Inkscape, then click the play/pause button, click any segment of the timeline to jump to that sample, and hover a segment to see its name | New controls. They need the file **opened as a document** — inside an ``, or in a viewer that blocks scripts, the buttons are inert by design and hovering the button still pauses | | [#140](https://github.com/reactome/WebsiteAngular/issues/140) | Flag a gene in the **genome-wide view**, with and without an analysis running | Flagging is now an outline instead of a fill, so the analysis colours survive underneath. Previously a flagged pathway lost its result colour, and without an analysis everything else was washed out | @@ -235,12 +235,42 @@ rather than parity: - The badge is not drawn below 0.6 zoom, where it is six pixels holding a two-digit number. The old browser stops drawing it too, at its own 0.5 tier. +**The count beside each resource now follows the pathway on screen.** It did not: +the tally was cleared only when a new count was stored, and nothing was ever +stored while the cache was full, so the second pathway you opened kept the first +one's numbers for the rest of the session. Reported from the browser and fixed — +worth one look, because the numbers were plausible rather than obviously wrong. + +**Your selection survives opening a pathway from inside the diagram.** Searching +for an entity and then double-clicking a pathway box replaced your selection with +the pathway you had just left, so a searched entity came back unselected. It is +kept now. The flag was never the problem — that always survived. + +**Downloading an illustration as SVG, PNG or JPEG works again on beta.** It had +been returning nothing at all: the exporter reads those from a directory on the +dev box that had been cleared to reclaim space, so the request 404'd while +ordinary diagram downloads carried on working (those are drawn in your browser, +not on the server). Restored for the pathways we test with. **If you hit an +illustration that still fails, that is why** — it is a gap in what is cached on +this machine, not a fault in the site. Issue #230 carries the proper fix. + +**Perturb now offers something.** The DeltaSignal panel had no pathways at all — +its catalogue was never wired up on this box, so the button appeared and did +nothing. Eleven pathways are generated now. The panel activates on those and +stays absent elsewhere, which is expected rather than broken. + +**One thing to know before asking for analysis reports by email.** If you leave +the address box empty, the analysis still runs and the reports are still made — +but no mail is sent and nothing says so. We do not enforce the address on our +side (#238), and the sending happens on a server we do not control (#168). So if +you want the email, check the box has your address in it before submitting. + **The interactor overlay now survives you moving around.** Choosing a resource and then opening another pathway used to lose it, including coming back to the pathway you chose it on — so the three clicks had to be repeated every time. It persists now, and a link carrying it opens with it drawn. -**The whole overlay is reachable from the keyboard.** The Species and Interactors +**The whole overlay is reachable from the keyboard.** The Species and Overlay controls could not be focused or activated without a mouse, and were announced to a screen reader as nothing at all. Both are operable now — Tab to them, Enter or Space to open, Escape to close — and closing returns you to where you were. diff --git a/RELEASE-TESTING.md b/RELEASE-TESTING.md index 2564fa635..285cbee6c 100644 --- a/RELEASE-TESTING.md +++ b/RELEASE-TESTING.md @@ -113,18 +113,20 @@ rows, the rows are right: this line has drifted twice from being edited by hand. ## Context menus and interactors -| Item | Status | -| -------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | -| Right-click an entity offers Molecule, Pathways, Interactors | **auto** — `diagram-entity-popup.spec.ts` | -| Pathways list navigates to a different diagram | **auto** — `diagram-entity-popup.spec.ts` | -| Interactor overlay draws, and clearing removes it | **auto** — `interactors.spec.ts`, asserted by looking at the diagram rather than at the button | -| Raising the confidence threshold reduces the interactors shown | **auto** — `interactor-threshold.spec.ts`, counting interactors visible on the diagram rather than the control's position | -| Interactor download | **auto** — `interactor-threshold.spec.ts`; the file carries every interaction the resource holds for the entity, not the filtered view | -| Adding your own interaction resource | **auto** — `custom-interactor-dialog.spec.ts`; a file or a paste is read in the browser and never uploaded unless a shareable link is asked for | -| Sharing an overlay by link | **auto** — `custom-interactor-dialog.spec.ts`; the link opens the same overlay for someone else, and the resource is listed so they can clear it | -| Deleting a resource you added | **auto** — `custom-interactor-dialog.spec.ts`, asserted on the diagram rather than on the list — the list emptying is what hid this being broken | -| An overlay survives navigating away and back | **auto** — `interactor-threshold.spec.ts`; counted in badges drawn, not in the address | -| Interactors reachable without a mouse | **auto** — `header-controls.spec.ts`; focus, Enter/Space to open, Escape to close, and focus returns to the control | +| Item | Status | +| --------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------ | +| Right-click an entity offers Molecule, Pathways, Interactors | **auto** — `diagram-entity-popup.spec.ts` | +| Pathways list navigates to a different diagram | **auto** — `diagram-entity-popup.spec.ts` | +| Interactor overlay draws, and clearing removes it | **auto** — `interactors.spec.ts`, asserted by looking at the diagram rather than at the button | +| Raising the confidence threshold reduces the interactors shown | **auto** — `interactor-threshold.spec.ts`, counting interactors visible on the diagram rather than the control's position | +| Interactor download | **auto** — `interactor-threshold.spec.ts`; the file carries every interaction the resource holds for the entity, not the filtered view | +| Adding your own interaction resource | **auto** — `custom-interactor-dialog.spec.ts`; a file or a paste is read in the browser and never uploaded unless a shareable link is asked for | +| Sharing an overlay by link | **auto** — `custom-interactor-dialog.spec.ts`; the link opens the same overlay for someone else, and the resource is listed so they can clear it | +| Deleting a resource you added | **auto** — `custom-interactor-dialog.spec.ts`, asserted on the diagram rather than on the list — the list emptying is what hid this being broken | +| An overlay survives navigating away and back | **auto** — `interactor-threshold.spec.ts`; counted in badges drawn, not in the address | +| The count beside a resource follows the pathway on screen | **auto** — `interactor-counts.spec.ts`; a unit test on the cache decision, because a browser test of it passed with and without the fix | +| Your selection survives opening a pathway from inside a diagram | **auto** — `diagram-behaviour.spec.ts`; asserted on `select` in the address, which is what survives a reload | +| Interactors reachable without a mouse | **auto** — `header-controls.spec.ts`; focus, Enter/Space to open, Escape to close, and focus returns to the control | ## Analysis tools From 538376827bdc7f367249b95916095c1798285ffb Mon Sep 17 00:00:00 2001 From: Adam Wright Date: Fri, 18 Sep 2026 03:21:06 +0000 Subject: [PATCH 2/2] =?UTF-8?q?docs(curators):=20drop=20the=20Perturb=20no?= =?UTF-8?q?te=20=E2=80=94=20it=20is=20not=20on=20beta?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I wrote that Perturb now offers something, having wired up DeltaSignal's catalogue on this box. Checked it against beta rather than against the box: buttons offered on beta.reactome.org/PathwayBrowser/R-HSA-69620: ["query_stats Analyze"] No Perturb. `deltaSignal: true` is set on the **development** profile only, and the comment beside it says why -- `proxy.conf.js` routes /api to a dev-server proxy that does not exist in a built artifact, so enabling it elsewhere would offer a button whose every call fails. Beta serves a production-shaped build. So the catalogue work is real and the endpoint answers, but a curator will not see any of it. A paragraph telling them to look would have sent them hunting for a button that is not there. Co-Authored-By: Claude Opus 5 --- CURATOR-REPORT.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/CURATOR-REPORT.md b/CURATOR-REPORT.md index bea428a19..ba8030c1f 100644 --- a/CURATOR-REPORT.md +++ b/CURATOR-REPORT.md @@ -254,11 +254,6 @@ not on the server). Restored for the pathways we test with. **If you hit an illustration that still fails, that is why** — it is a gap in what is cached on this machine, not a fault in the site. Issue #230 carries the proper fix. -**Perturb now offers something.** The DeltaSignal panel had no pathways at all — -its catalogue was never wired up on this box, so the button appeared and did -nothing. Eleven pathways are generated now. The panel activates on those and -stays absent elsewhere, which is expected rather than broken. - **One thing to know before asking for analysis reports by email.** If you leave the address box empty, the analysis still runs and the reports are still made — but no mail is sent and nothing says so. We do not enforce the address on our