From c855725685c24c30f53e84a2e6f95fd462e084b2 Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Mon, 6 Nov 2017 11:52:31 -0800 Subject: [PATCH 1/2] Fixes version detection. --- PCbuild/python.props | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/PCbuild/python.props b/PCbuild/python.props index 2d48ed1e362b5a1..a826bbf283e019f 100644 --- a/PCbuild/python.props +++ b/PCbuild/python.props @@ -73,14 +73,13 @@ possible version). Since we limit WINVER to Windows 7 anyway, it doesn't really matter which WinSDK version we use. --> - 10.0.15063.0 - 10.0.15063.0 - 10.0.14393.0 - 10.0.14393.0 - 10.0.10586.0 - 10.0.10586.0 - 10.0.10240.0 - 10.0.10240.0 + <_RegistryVersion>$(Registry:HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion) + <_RegistryVersion Condition="$(_RegistryVersion) == ''">$(Registry:HKEY_LOCAL_MACHINE\WOW6432Node\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v10.0@ProductVersion) + 10.0.16299.0 + 10.0.15063.0 + 10.0.14393.0 + 10.0.10586.0 + 10.0.10240.0 From c278afa032855f7a072aa5344e4c4e7cf971b780 Mon Sep 17 00:00:00 2001 From: Steve Dower Date: Mon, 6 Nov 2017 11:54:00 -0800 Subject: [PATCH 2/2] Adds NEWS item --- Misc/NEWS.d/next/Build/2017-11-06-11-53-39.bpo-31957.S_1jFK.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Build/2017-11-06-11-53-39.bpo-31957.S_1jFK.rst diff --git a/Misc/NEWS.d/next/Build/2017-11-06-11-53-39.bpo-31957.S_1jFK.rst b/Misc/NEWS.d/next/Build/2017-11-06-11-53-39.bpo-31957.S_1jFK.rst new file mode 100644 index 000000000000000..ffee9025a7bf548 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2017-11-06-11-53-39.bpo-31957.S_1jFK.rst @@ -0,0 +1 @@ +Fixes Windows SDK version detection when building for Windows.