Skip to content

Fix FilteredActionList skeleton SSR widths#7929

Draft
joshblack wants to merge 5 commits into
docs/add-stories-and-snapshots-for-filtered-action-listfrom
joshblack/issue-6386-ssr-safe-loaders
Draft

Fix FilteredActionList skeleton SSR widths#7929
joshblack wants to merge 5 commits into
docs/add-stories-and-snapshots-for-filtered-action-listfrom
joshblack/issue-6386-ssr-safe-loaders

Conversation

@joshblack

@joshblack joshblack commented Jun 5, 2026

Copy link
Copy Markdown
Member

Changelog

New

N/A

Changed

  • FilteredActionList body skeleton rows now use deterministic CSS-module widths instead of render-time randomness, making the loading state SSR-compatible.

Removed

  • Removed the redundant FilteredActionListBodyLoader test asserting that Math.random is not called.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • npx vitest run packages/react/src/FilteredActionList/FilteredActionList.test.tsx
  • npm run format:diff
  • npm run lint
  • npm run lint:css
  • npm run type-check
  • npm run build
  • npm test -- --run
  • Storybook started successfully and responded for /?path=/story/components-filteredactionlist--default

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9640da4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

Comment thread packages/react/src/FilteredActionList/FilteredActionList.test.tsx Outdated
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 5, 2026 19:11 Inactive
@github-actions github-actions Bot temporarily deployed to storybook-preview-7929 June 5, 2026 21:30 Inactive
@joshblack joshblack changed the base branch from main to docs/add-stories-and-snapshots-for-filtered-action-list June 8, 2026 20:16
@joshblack joshblack force-pushed the docs/add-stories-and-snapshots-for-filtered-action-list branch from f2a7f31 to 9c9f6fa Compare June 8, 2026 20:27
@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 30b6ce8 to 31f823b Compare June 8, 2026 20:27
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 8, 2026 20:31 Abandoned
joshblack and others added 3 commits June 8, 2026 15:33
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@primer

primer Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint and formatting issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the joshblack/issue-6386-ssr-safe-loaders branch from 2e12404 to 23c71fb Compare June 8, 2026 20:35
@joshblack joshblack force-pushed the docs/add-stories-and-snapshots-for-filtered-action-list branch from 9c9f6fa to 240df94 Compare June 8, 2026 20:35
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 8, 2026
@github-actions github-actions Bot requested a deployment to storybook-preview-7929 June 8, 2026 20:39 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants