diff --git a/apps/desktop/src/window/DesktopApplicationMenu.test.ts b/apps/desktop/src/window/DesktopApplicationMenu.test.ts index c1bb89b759e6b..612ec441ba99b 100644 --- a/apps/desktop/src/window/DesktopApplicationMenu.test.ts +++ b/apps/desktop/src/window/DesktopApplicationMenu.test.ts @@ -4,7 +4,12 @@ import * as Deferred from "effect/Deferred"; import * as Effect from "effect/Effect"; import * as Layer from "effect/Layer"; -import type * as Electron from "electron"; +import * as Electron from "electron"; +import { vi } from "vite-plus/test"; + +vi.mock("electron", () => ({ + webContents: { getAllWebContents: vi.fn(() => []) }, +})); import * as ElectronApp from "../electron/ElectronApp.ts"; import * as ElectronDialog from "../electron/ElectronDialog.ts"; @@ -227,10 +232,32 @@ describe("DesktopApplicationMenu", () => { items.find((item) => item.role === "windowMenu" && item.submenu === undefined), platform, ); - assert.isUndefined( - items.find((item) => item.accelerator?.toLowerCase().endsWith("+w")), - platform, - ); + const closeTools = items.find((item) => item.accelerator === "CmdOrCtrl+W"); + assert.equal(closeTools?.label, "Close Developer Tools", platform); + assert.isFunction(closeTools?.click); + const appContents = { + isDestroyed: () => false, + isDevToolsFocused: () => false, + closeDevTools: vi.fn(), + }; + const inspectedContents = { + ...appContents, + isDevToolsFocused: () => true, + closeDevTools: vi.fn(), + }; + using allContents = vi + .spyOn(Electron.webContents, "getAllWebContents") + .mockReturnValue([ + appContents as unknown as Electron.WebContents, + inspectedContents as unknown as Electron.WebContents, + ]); + closeTools?.click?.({} as Electron.MenuItem, undefined, {} as KeyboardEvent); + assert.equal(inspectedContents.closeDevTools.mock.calls.length, 1); + assert.equal(appContents.closeDevTools.mock.calls.length, 0); + + allContents.mockReturnValue([appContents as unknown as Electron.WebContents]); + closeTools?.click?.({} as Electron.MenuItem, undefined, {} as KeyboardEvent); + assert.equal(appContents.closeDevTools.mock.calls.length, 0); } }), ); diff --git a/apps/desktop/src/window/DesktopApplicationMenu.ts b/apps/desktop/src/window/DesktopApplicationMenu.ts index 07fd8654af6be..44d2c234f8358 100644 --- a/apps/desktop/src/window/DesktopApplicationMenu.ts +++ b/apps/desktop/src/window/DesktopApplicationMenu.ts @@ -4,7 +4,7 @@ import * as Layer from "effect/Layer"; import * as Option from "effect/Option"; import * as Schema from "effect/Schema"; -import type * as Electron from "electron"; +import * as Electron from "electron"; import { makeComponentLogger } from "../app/DesktopObservability.ts"; import * as ElectronDialog from "../electron/ElectronDialog.ts"; @@ -200,6 +200,17 @@ export const make = Effect.gen(function* () { }, { type: "separator" as const }, ]), + { + label: "Close Developer Tools", + accelerator: "CmdOrCtrl+W", + visible: false, + click: () => { + Electron.webContents + .getAllWebContents() + .find((contents) => !contents.isDestroyed() && contents.isDevToolsFocused()) + ?.closeDevTools(); + }, + }, // Cmd/Ctrl+W belongs to the renderer's tab close; it must never close the window. environment.platform === "darwin" ? { label: "Close Window", click: (_item, window) => window?.close() } diff --git a/apps/desktop/src/window/DesktopWindow.test.ts b/apps/desktop/src/window/DesktopWindow.test.ts index c599e624631f9..03b9a2e6ad64a 100644 --- a/apps/desktop/src/window/DesktopWindow.test.ts +++ b/apps/desktop/src/window/DesktopWindow.test.ts @@ -94,6 +94,7 @@ function makeFakeBrowserWindow() { replaceMisspelling: vi.fn(), send: vi.fn(), setBackgroundThrottling: vi.fn(), + setIgnoreMenuShortcuts: vi.fn(), setWindowOpenHandler: vi.fn(), toggleDevTools: vi.fn(), }; @@ -143,6 +144,7 @@ function makeFakeBrowserWindow() { reloadIgnoringCache: webContents.reloadIgnoringCache, toggleDevTools: webContents.toggleDevTools, navigationHistory: webContents.navigationHistory, + setIgnoreMenuShortcuts: webContents.setIgnoreMenuShortcuts, send: webContents.send, setZoomLevel: webContents.setZoomLevel, setWindowButtonPosition: window.setWindowButtonPosition, @@ -646,7 +648,7 @@ describe("DesktopWindow", () => { }), ); - it.effect("blocks only repeated Cmd+W input before it reaches the native window menu", () => + it.effect("leaves Cmd+W to the renderer and blocks repeated presses", () => Effect.gen(function* () { const fakeWindow = makeFakeBrowserWindow(); const createCount = yield* Ref.make(0); @@ -687,6 +689,13 @@ describe("DesktopWindow", () => { prevented = false; beforeInput(event, { ...input, meta: false }); assert.isFalse(prevented); + + assert.deepEqual( + fakeWindow.setIgnoreMenuShortcuts.mock.calls.map(([ignore]) => ignore), + [true, true, false], + ); + beforeInput(event, { ...input, key: "r", isAutoRepeat: false }); + assert.isFalse(fakeWindow.setIgnoreMenuShortcuts.mock.lastCall?.[0]); }).pipe(Effect.provide(layer)); }), ); diff --git a/apps/desktop/src/window/DesktopWindow.ts b/apps/desktop/src/window/DesktopWindow.ts index 14de53d31d3bc..17dba6742f795 100644 --- a/apps/desktop/src/window/DesktopWindow.ts +++ b/apps/desktop/src/window/DesktopWindow.ts @@ -677,6 +677,13 @@ export const make = Effect.gen(function* () { }); window.webContents.on("before-input-event", (event, input) => { quitShortcutHandler(event, input); + // Cmd/Ctrl+W reaches the renderer; DevTools uses the native menu shortcut. + window.webContents.setIgnoreMenuShortcuts( + (environment.platform === "darwin" ? input.meta : input.control) && + !input.alt && + !input.shift && + input.key.toLowerCase() === "w", + ); // A held Cmd/Ctrl+W closes one tab or terminal, not each one behind it. if (input.type !== "keyDown" || !input.isAutoRepeat) return; const modifier = environment.platform === "darwin" ? input.meta : input.control;