Skip to content

Commit cb4fe60

Browse files
fix(web): show the thread details tooltip (#24864)
1 parent dac58fa commit cb4fe60

1 file changed

Lines changed: 11 additions & 13 deletions

File tree

‎apps/web/src/components/chat/PanelLayoutControls.tsx‎

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { PanelBottomIcon, PanelRightIcon, SquareMenuIcon } from "lucide-react";
22
import { Maximize2, Minimize2 } from "lucide";
33
import { MorphIcon } from "~/components/MorphIcon";
4-
import { memo, type ReactElement, type ReactNode } from "react";
4+
import { memo, type ReactNode } from "react";
55

66
import { cn } from "~/lib/utils";
77

@@ -53,19 +53,23 @@ export const PanelLayoutControls = memo(function PanelLayoutControls({
5353
<Toggle
5454
className="relative shrink-0 [-webkit-app-region:no-drag]"
5555
pressed={threadPanelOpen}
56+
onPressedChange={threadPanelPresentation === "popover" ? undefined : onToggleThreadPanel}
5657
aria-label="Toggle thread details panel"
5758
variant="ghost"
5859
size="sm"
5960
>
6061
<SquareMenuIcon className="size-4" />
6162
</Toggle>
6263
);
63-
const threadPanelTooltip = (trigger: ReactElement) => (
64+
const threadPanelControl = (
6465
<Tooltip>
65-
<TooltipTrigger
66-
render={trigger}
67-
{...(threadPanelPresentation === "popover" ? {} : { onClick: onToggleThreadPanel })}
68-
/>
66+
<TooltipTrigger render={<span className="flex shrink-0" />}>
67+
{threadPanelPresentation === "popover" ? (
68+
<PopoverTrigger handle={threadPanelPopoverHandle} render={threadPanelToggle} />
69+
) : (
70+
threadPanelToggle
71+
)}
72+
</TooltipTrigger>
6973
<TooltipPopup side="bottom">
7074
Toggle thread details
7175
{threadPanelShortcutLabel ? ` (${threadPanelShortcutLabel})` : ""}
@@ -78,13 +82,7 @@ export const PanelLayoutControls = memo(function PanelLayoutControls({
7882
className="flex h-full shrink-0 items-center gap-1 [-webkit-app-region:no-drag]"
7983
data-panel-layout-controls
8084
>
81-
{showThreadPanelControl
82-
? threadPanelPresentation === "popover"
83-
? threadPanelTooltip(
84-
<PopoverTrigger handle={threadPanelPopoverHandle} render={threadPanelToggle} />,
85-
)
86-
: threadPanelTooltip(threadPanelToggle)
87-
: null}
85+
{showThreadPanelControl ? threadPanelControl : null}
8886
{showTerminalControl ? (
8987
<Tooltip>
9088
<TooltipTrigger render={<span className="flex shrink-0" />}>

0 commit comments

Comments
 (0)