Skip to content

chore: fix hero props table#12562

Open
mcoker wants to merge 1 commit into
patternfly:mainfrom
mcoker:hero-props
Open

chore: fix hero props table#12562
mcoker wants to merge 1 commit into
patternfly:mainfrom
mcoker:hero-props

Conversation

@mcoker

@mcoker mcoker commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

fixes #12561

Summary by CodeRabbit

  • Refactor
    • Improved type safety for the Hero component’s properties without changing its behavior or appearance.

@mcoker mcoker requested review from kmcfaul and thatblindgeye July 14, 2026 20:36
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8441cee7-e0be-42d6-a3d7-4bb8a988e9f0

📥 Commits

Reviewing files that changed from the base of the PR and between c9faa23 and 337cdd7.

📒 Files selected for processing (1)
  • packages/react-core/src/components/Hero/Hero.tsx

Walkthrough

The Hero component’s destructured props parameter now explicitly uses HeroProps, with no runtime logic changes.

Changes

Hero props typing

Layer / File(s) Summary
Annotate Hero props parameter
packages/react-core/src/components/Hero/Hero.tsx
Adds an explicit HeroProps type annotation to the Hero component’s destructured props parameter.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: thatblindgeye

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and directly describes the Hero props table fix.
Linked Issues check ✅ Passed The change addresses #12561 by adjusting Hero prop typing so docs can surface all props.
Out of Scope Changes check ✅ Passed Only the Hero component typing was changed, with no unrelated code or behavior added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Hero props are not showing up in docs

2 participants