Skip to content

Commit faa74ef

Browse files
committed
Drop the Spotless block waiting for baseline-format
The benchmarks build kept upstream's Spotless configuration commented out, to come back with baseline-format. baseline is gone and nothing in the build applies Spotless; dev.openjavaformat.java-format formats the repository. What the block said still matters, so a comment keeps it: the symlinked test input must not be formatted.
1 parent 5cbf8ec commit faa74ef

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

‎open-java-format-benchmarks/build.gradle‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,8 @@ tasks.named('jmh', JMHTask.class) {
3232
environment.put('JARS_CLASSPATH', configurations.named('formatterNativeJars').map { conf -> conf.collect { it.absolutePath }.join(":") })
3333
}
3434

35-
// Spotless is off for now: baseline-format is not applied, because Spotless 8.10.2
36-
// cannot be serialised into the configuration cache. Restore this block together
37-
// with baseline-format once that is fixed upstream.
38-
// spotless {
39-
// java {
40-
// // symlinks to a test input file that shouldn't be formatted
41-
// targetExclude 'src/test/resources/*'
42-
// }
43-
// }
35+
// src/test/resources/PalantirDeeplyNestedCalls.java is a symlink to a formatter test input, which has to
36+
// keep its unformatted shape: leave src/test/resources out of any formatting step added to this build.
4437

4538
jmhCompileGeneratedClasses {
4639
options.errorprone.enabled = false

0 commit comments

Comments
 (0)