Replace palantir's Gradle plugins with plain Gradle

The build no longer applies anything from palantir's Gradle tooling.
What it used to get from there is now written out in two buildSrc
convention plugins, or comes from the plain upstream plugins:

- open-java-format.error-prone-conventions runs Error Prone 2.50.0
  through net.ltgt.errorprone and net.ltgt.nullaway, with NullAway and
  Picnic's error-prone-support, in place of baseline-error-prone,
  baseline-null-away, suppressible-error-prone and gradle-guide, which
  applied suppressible-error-prone itself. The checks vfs-s3 makes
  build-breaking are listed there, commented out until the code is
  fixed.
- open-java-format.java-conventions sets what gradle-baseline-java did:
  the Java 21 toolchain, tests on -PjavaRuntime, the JUnit wiring, the
  javac flags and Checkstyle. The IntelliJ Platform plugin defaults
  javac to --release, which javac refuses alongside the --add-exports
  of jdk.compiler; baseline hid that, and the IDEA plugin's build now
  unsets it.
- Checkstyle's configuration moves from .baseline/checkstyle to
  Gradle's default config/checkstyle and runs on Checkstyle 14.3.0,
  without JavadocStyle, which Checkstyle 13.9.0 removed.
  custom-suppressions.xml still suppresses every check, as upstream.
- The released dev.openjavaformat.java-format 2.98.0.5 formats the
  repository instead of com.palantir.java-format, which needed Spotless
  on the classpath once baseline no longer brought it.
- The version comes from git describe, the same command
  gradle-git-version ran. failure-reports, idea-language-injector and
  jakarta-package-alignment go without replacement, and so do the
  configuration files of palantir's bots: bulldozer, changelog,
  excavator and revapi.

Author: abashev

.bulldozer.yml

@@ -4,56 +4,38 @@ buildscript {
         gradlePluginPortal()
     }
 
-
     dependencies {
-        classpath 'com.palantir.jakartapackagealignment:jakarta-package-alignment:0.7.0'
         classpath 'com.gradle.publish:plugin-publish-plugin:2.2.1'
-        classpath 'com.palantir.baseline-error-prone:gradle-baseline-error-prone:0.7.0'
-        classpath 'com.palantir.baseline:gradle-baseline-java:7.9.0'
-        classpath 'com.palantir.gradle.failure-reports:gradle-failure-reports:1.21.0'
-        classpath 'com.palantir.gradle.gitversion:gradle-git-version:5.1.0'
-        classpath 'com.palantir.gradle.guide:gradle-guide:1.27.0'
-        classpath 'com.palantir.gradle.idea-configuration:gradle-idea-configuration:0.11.0'
-        classpath 'com.palantir.gradle.idea-language-injector:gradle-idea-language-injector:0.5.0'
-        classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.98.0'
-        classpath 'com.palantir.suppressible-error-prone:gradle-suppressible-error-prone:2.33.0'
+        // The released open-java-format formats this repository, not the one being built here.
+        classpath 'dev.openjavaformat:gradle-open-java-format:2.98.0.5'
         classpath 'me.champeau.jmh:jmh-gradle-plugin:0.7.3'
     }
 }
 
-apply plugin: 'com.palantir.failure-reports'
-apply plugin: 'com.palantir.git-version'
-apply plugin: 'com.palantir.gradle-guide'
-apply plugin: 'com.palantir.idea-language-injector'
-// Not the `com.palantir.baseline` aggregate: it also applies baseline-format (Spotless) and
-// baseline-class-uniqueness, and both are incompatible with the configuration cache at their
-// latest versions — Spotless fails serialising its Groovy extension, checkClassUniqueness casts
-// a ResolvingFileCollection to Configuration. The rest of what baseline gives us is applied
-// per project below, so error-prone and the JUnit wiring survive.
-apply plugin: 'com.palantir.baseline-error-prone-root'
-apply plugin: 'com.palantir.baseline-java-versions'
 // Maven Central releases: buildSrc/src/main/groovy/open-java-format.release-conventions.gradle.
 apply plugin: 'open-java-format.release-conventions'
 
 // GitHub Actions sets GITHUB_REF_TYPE=tag on a tag build; otherwise derive the
-// version from git history (needs a full clone: actions/checkout fetch-depth: 0).
+// version from git history (needs a full clone: actions/checkout fetch-depth: 0):
+// the nearest tag, the commits since it and the hash, `.dirty` with uncommitted changes.
 //
 // Read through providers rather than System.env: the configuration cache tracks a provider as an input
 // and invalidates when it changes, while a plain System.env read is invisible to it — a cached
 // configuration then keeps handing out the version of whichever environment happened to fill it.
 def refType = providers.environmentVariable('GITHUB_REF_TYPE')
 def refName = providers.environmentVariable('GITHUB_REF_NAME')
-version refType.getOrElse('') == 'tag' ? refName.get() : gitVersion()
+def gitDescribe = providers.exec {
+    commandLine 'git', 'describe', '--tags', '--always', '--first-parent', '--abbrev=7', '--dirty=.dirty'
+}.standardOutput.asText.map { it.trim() }
+version refType.getOrElse('') == 'tag' ? refName.get() : gitDescribe.get()
 
 // The GraalVM image is built by its own per-platform CI job, never as a side effect of
 // `./gradlew build`: an aggregate build must not require a GraalVM toolchain on a machine that
 // only wants the jars. Pass -PnativeImage=true to wire it back into the lifecycle tasks — that is
 // what .github/workflows/ci.yml's `native` jobs do.
 ext.nativeImageRequested = Boolean.parseBoolean(providers.gradleProperty('nativeImage').getOrElse('false'))
 
-// The javac internals the formatter parses with. Was baseline's `moduleJvmArgs`, which is
-// dropped because it resolves its extension at execution time and the configuration cache
-// forbids that — so the exports are handed to javac and to the test JVMs here instead.
+// The javac internals the formatter parses with, handed to javac and to the test JVMs.
 def javacInternalExports = [
         'jdk.compiler/com.sun.tools.javac.api',
         'jdk.compiler/com.sun.tools.javac.code',
@@ -65,18 +47,8 @@ def javacInternalExports = [
 ]
 
 allprojects {
-    apply plugin: 'com.palantir.baseline-null-away'
-    apply plugin: 'com.palantir.baseline-encoding'
-    apply plugin: 'com.palantir.baseline-immutables'
-    apply plugin: 'com.palantir.baseline-java-compiler-diagnostics'
-    apply plugin: 'com.palantir.baseline-java-compiler-heap'
-    apply plugin: 'com.palantir.baseline-java-properties'
-    apply plugin: 'com.palantir.baseline-prefer-project-modules'
-    apply plugin: 'com.palantir.baseline-reproducibility'
-    apply plugin: 'com.palantir.baseline-test-heap'
-    apply plugin: com.palantir.baseline.plugins.BaselineTesting
-    apply plugin: 'com.palantir.java-format'
-    apply plugin: 'com.palantir.jakarta-package-alignment'
+    apply plugin: 'dev.openjavaformat.java-format'
+
     // The fork's Maven group (README, "Coordinates"). The Java packages stay com.palantir.javaformat.
     group = 'dev.openjavaformat'
     version = rootProject.version
@@ -95,8 +67,8 @@ allprojects {
     tasks.withType(Javadoc).configureEach {
         options.addMultilineStringsOption('-add-exports')
                 .setValue(javacInternalExports.collect { "${it}=ALL-UNNAMED".toString() })
-        // baseline used to silence doclint; these sources carry inherited javadoc from
-        // google-java-format that has never satisfied it (unknown tags, malformed HTML).
+        // These sources carry inherited javadoc from google-java-format that has never
+        // satisfied doclint (unknown tags, malformed HTML).
         options.addStringOption('Xdoclint:none', '-quiet')
     }
 
@@ -108,33 +80,12 @@ allprojects {
 
 subprojects {
     apply plugin: 'java-library'
+    // Java toolchains, javac and test settings; Error Prone. Both in buildSrc/src/main/groovy.
+    apply plugin: 'open-java-format.java-conventions'
+    apply plugin: 'open-java-format.error-prone-conventions'
 
     dependencies {
-        // Gives a version to the JUnit artifacts that plugins add without one.
+        // Gives a version to the JUnit artifacts that useJUnitJupiter() adds without one.
         testImplementation platform(libs.junit.bom)
     }
-
-    tasks.withType(Checkstyle).configureEach {
-        enabled = false
-    }
-
-    tasks.withType(JavaCompile).configureEach {
-        options.errorprone.disable 'PreconditionsConstantMessage', 'PreferSafeLoggableExceptions', 'PreferSafeLoggingPreconditions'
-        options.errorprone.disable 'StrictUnusedVariable'
-    }
-
-    // Run `./gradlew test -Drecreate=true` to recreate all the expected
-    // generated code that we have checked into the repo.
-    tasks.withType(Test).configureEach {
-        systemProperty 'recreate', System.getProperty('recreate', 'false')
-    }
-}
-
-// The JDK the tests run on, and with it the javac whose internals the formatter parses with. The code is
-// compiled for 21 whatever this says. CI's `jdk` jobs pass -PjavaRuntime=25 and so on.
-ext.javaRuntime = providers.gradleProperty('javaRuntime').getOrElse('21')
-
-javaVersions {
-    libraryTarget = 21
-    runtime = javaRuntime
 }

.changelog.yml

@@ -11,5 +11,7 @@ repositories {
 }
 
 dependencies {
+    implementation 'net.ltgt.gradle:gradle-errorprone-plugin:5.1.1'
+    implementation 'net.ltgt.gradle:gradle-nullaway-plugin:3.2.0'
     implementation 'org.jreleaser:org.jreleaser.gradle.plugin:1.26.0'
 }

.excavator.yml

@@ -0,0 +1,53 @@
+// Error Prone with NullAway and Picnic's error-prone-support checks, on the plain net.ltgt plugins.
+plugins {
+    id 'net.ltgt.errorprone'
+    id 'net.ltgt.nullaway'
+}
+
+dependencies {
+    errorprone libs.errorprone.core
+    errorprone libs.nullaway
+    errorprone libs.errorProneSupport.contrib
+}
+
+nullaway {
+    annotatedPackages.add('com.palantir')
+}
+
+tasks.withType(JavaCompile).configureEach {
+    options.errorprone {
+        // Annotation processor output (derive4j, Immutables) is not ours to fix.
+        excludedPaths = '.*/build/generated/.*'
+    }
+}
+
+// Gradle injects services through abstract @Inject getters, which is what this check forbids.
+pluginManager.withPlugin('java-gradle-plugin') {
+    tasks.withType(JavaCompile).configureEach {
+        options.errorprone.disable('JavaxInjectOnAbstractMethod')
+    }
+}
+
+// The checks vfs-s3 makes build-breaking. Off until the code is fixed, one check at a time:
+// JUnitMethodDeclaration 206, StaticImport 84, LexicographicalAnnotationListing 46, JUnitClassModifiers 25,
+// RedundantStringConversion 6, AlmostJavadoc 3 findings; the rest have none.
+//tasks.withType(JavaCompile).configureEach {
+//    options.errorprone {
+//        error('StaticImport')
+//        error('UnnecessarilyFullyQualified')
+//        error('EmptyBlockTag')
+//        error('OperatorPrecedence')
+//        error('RedundantStringConversion')
+//        error('PatternMatchingInstanceof')
+//        error('UnnecessaryParentheses')
+//        error('LexicographicalAnnotationListing')
+//        error('JUnitMethodDeclaration')
+//        error('JUnitClassModifiers')
+//        error('MissingSummary')
+//        error('AlmostJavadoc')
+//        error('BadImport')
+//        error('JdkObsolete')
+//        // NonStaticImport (Picnic) is the inverse of StaticImport and would give contradictory advice.
+//        disable('NonStaticImport')
+//    }
+//}

.palantir/revapi.yml

@@ -0,0 +1,67 @@
+// Java compilation and tests for every module: what palantir/gradle-baseline used to set, in plain Gradle.
+plugins {
+    id 'java'
+    id 'checkstyle'
+}
+
+// The JDK the tests run on, and with it the javac whose internals the formatter parses with. The code is
+// compiled for 21 whatever this says. CI's `jdk` jobs pass -PjavaRuntime=25 and so on.
+ext.javaRuntime = providers.gradleProperty('javaRuntime').getOrElse('21')
+
+java {
+    toolchain {
+        languageVersion = JavaLanguageVersion.of(21)
+    }
+}
+
+configurations.configureEach {
+    resolutionStrategy.preferProjectModules()
+}
+
+tasks.withType(JavaCompile).configureEach {
+    options.encoding = 'UTF-8'
+    options.compilerArgs.addAll('-parameters', '-Xmaxwarns', '10000', '-Xmaxerrs', '10000')
+}
+
+tasks.withType(Javadoc).configureEach {
+    options.encoding = 'UTF-8'
+    options.tags('apiNote', 'implSpec', 'implNote')
+}
+
+// The configuration is Gradle's default, config/checkstyle in the root project.
+checkstyle {
+    toolVersion = libs.versions.checkstyle.get()
+}
+
+tasks.withType(AbstractArchiveTask).configureEach {
+    duplicatesStrategy = DuplicatesStrategy.WARN
+}
+
+testing {
+    suites {
+        test {
+            useJUnitJupiter()
+        }
+    }
+}
+
+tasks.withType(Test).configureEach {
+    javaLauncher = javaToolchains.launcherFor {
+        languageVersion = JavaLanguageVersion.of(javaRuntime)
+    }
+    maxHeapSize = '2g'
+    jvmArgs '-XX:+HeapDumpOnOutOfMemoryError', '-XX:+CrashOnOutOfMemoryError'
+
+    systemProperty 'junit.platform.output.capture.stdout', 'true'
+    systemProperty 'junit.platform.output.capture.stderr', 'true'
+    systemProperty 'junit.jupiter.execution.parallel.enabled', 'true'
+    systemProperty 'junit.jupiter.execution.parallel.config.strategy', 'dynamic'
+    testLogging.events 'failed'
+
+    // Run `./gradlew test -Drecreate=true` to recreate all the expected
+    // generated code that we have checked into the repo.
+    def recreate = Boolean.getBoolean('recreate')
+    systemProperty 'recreate', recreate.toString()
+    outputs.upToDateWhen { !recreate }
+    outputs.cacheIf { false }
+}

build.gradle

@@ -1,5 +1,3 @@
-// Applied by every module with a Maven publication: the POM Maven Central requires, and a local
-// `staging` repository that JReleaser signs and uploads from (open-java-format.release-conventions).
 plugins {
     id 'maven-publish'
 }
@@ -61,6 +59,7 @@ publishing {
 def cleanStagingDeploy = tasks.register('cleanStagingDeploy', Delete) {
     delete stagingDeploy
 }
+
 tasks.withType(PublishToMavenRepository).configureEach {
     if (name.endsWith('ToStagingRepository')) {
         dependsOn cleanStagingDeploy

buildSrc/build.gradle

@@ -17,9 +17,6 @@
     <!-- Suppress test resources -->
     <suppress files="[/\\]src[/\\]test[/\\]resources.*" checks="." />
 
-    <!-- JavadocStyle enforces existence of package-info.java package-level Javadoc; we consider this a bug. -->
-    <suppress files="package-info.java" checks="JavadocStyle" />
-
     <!-- non-code classes -->
     <suppress files="\.(bdr|eot|gif|gzip|jar|json|otf|png|svg|ttf|woff|zip)$" checks="FileTabCharacter" />
     <suppress files="\.(bdr|eot|gif|gzip|jar|json|otf|png|svg|ttf|woff|zip)$" checks="NewlineAtEndOfFile" />