Skip to content

Commit 4f407a9

Browse files
authored
Merge branch 'main' into records-instead-of-immutables
2 parents 679e5a7 + b1e3c41 commit 4f407a9

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,16 @@ jobs:
2222
with:
2323
persist-credentials: false
2424

25+
# setup-java's problem matcher turns javac's warnings, Error Prone's among them, into annotations on
26+
# the diff. This is the one job that keeps it: every other job compiles the same sources, and with
27+
# the matcher on there too each warning showed once per job. GitHub keeps only the first ten
28+
# warnings of a step, so the annotations are the first ten warnings the parallel build prints.
2529
- name: Install JDK 21
2630
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
2731
with:
2832
distribution: temurin
2933
java-version: '21'
34+
problem-matcher: true
3035

3136
- name: Build
3237
run: ./gradlew test
@@ -68,19 +73,22 @@ jobs:
6873
with:
6974
persist-credentials: false
7075

76+
# No problem matcher in this job: `build` annotates the warnings.
7177
- name: Install JDK ${{ matrix.jdk }} for the tests
7278
id: test-jdk
7379
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
7480
with:
7581
distribution: temurin
7682
java-version: ${{ matrix.jdk }}
83+
problem-matcher: false
7784

7885
# Installed last, so that it is the JAVA_HOME Gradle runs and compiles on.
7986
- name: Install JDK 21
8087
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
8188
with:
8289
distribution: temurin
8390
java-version: '21'
91+
problem-matcher: false
8492

8593
- name: Explain the extra Gradle arguments
8694
if: ${{ matrix.gradle_args != '' }}
@@ -138,13 +146,15 @@ jobs:
138146

139147
# The jars compile with a Java 21 toolchain, which gradle.properties looks up in JDK21_HOME. On
140148
# Linux and macOS Gradle also finds the runner's own JDK 21 by its location, on Windows it does not.
141-
# Installed before GraalVM, so that Gradle itself still runs on GraalVM.
149+
# Installed before GraalVM, so that Gradle itself still runs on GraalVM. No problem matcher: `build`
150+
# annotates the warnings.
142151
- name: Install JDK 21 for the jars
143152
id: jdk21
144153
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
145154
with:
146155
distribution: temurin
147156
java-version: '21'
157+
problem-matcher: false
148158

149159
- name: Install GraalVM 25 for the image
150160
uses: graalvm/setup-graalvm@0426e2e191540e8514dff98dc52a5f5146a2a276 # v1.6.6

‎.github/workflows/codeql-analysis.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,13 @@ jobs:
3030
with:
3131
persist-credentials: false
3232

33+
# No problem matcher: the javac warnings are annotated by CI's `build` job.
3334
- name: Set up JDK 21
3435
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
3536
with:
3637
distribution: temurin
3738
java-version: '21'
39+
problem-matcher: false
3840

3941
- name: Initialize CodeQL
4042
uses: github/codeql-action/init@1c5b675653bb5c22dbe9b12b556ec555138e09fd # v4.38.1

0 commit comments

Comments
 (0)