Repository navigation
fix(deps): update starlette requirement from >=1.7.0 to >=1.9.0 in /examples/realtime/twilio_sip - #5437
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: def2ac000c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Updates the requirements on [starlette](https://github.com/Kludex/starlette) to permit the latest version. - [Release notes](https://github.com/Kludex/starlette/releases) - [Changelog](https://github.com/Kludex/starlette/blob/main/docs/release-notes.md) - [Commits](Kludex/starlette@1.7.0...1.9.0) --- updated-dependencies: - dependency-name: starlette dependency-version: 1.9.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
def2ac0 to
f6a00f5
Compare
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the complete final PR diff and combined integration with two independent reviewers; no remaining blocking findings. The final Python markers preserve documented Python 3.10 compatibility while applying the update on Python 3.11+. Requirements resolve on both interpreter generations, and all 51 Twilio tests passed with the actual upgraded Starlette/HTTPX2/FastAPI versions. Merge remains contingent on fresh CI completing successfully.
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed e4c1563f07df24245cb16cfe6e361ed2bc6c8477. The split Starlette requirements preserve starlette>=1.7.0 on Python 3.10 and require >=1.9.0 on Python 3.11 and later. The markers are exhaustive and non-overlapping, and the remaining example requirements are unchanged. This resolves the earlier unconditional-floor compatibility finding.
Source-only review; I did not execute candidate code, install dependencies, or rerun the author-reported focused tests. Hosted checks on this head: 23 passed and 2 skipped. No remaining actionable finding in this change.
Updates the requirements on starlette to permit the latest version.
Release notes
Sourced from starlette's releases.
Changelog
Sourced from starlette's changelog.
... (truncated)
Commits
1840c9dVersion 1.9.0 (#3676)750dc33Preserve allVaryheaders inMutableHeaders.add_vary_header(#3675)414af4fRemove unmaintained packages from the third-party packages page (#3674)d4df01aAdd adminsite to the third-party packages (#3654)1766228Match host names case-insensitively inHostrouting and `TrustedHostMiddlew...a579222IncludeHEADin theAllowheader ofHTTPEndpoint405 responses (#3585)6b11cd7Honor streaming responses in TestClient (#3491)b7901fbUse byte length for typedmemoryviewresponse bodies (#3622)3214cd0Escape path delimiters and leading//when building URLs (#3671)7b2948fVersion 1.8.0 (#3660)