fix: stop forcing --no-clear on programmatic commands

Author: danielroe

packages/nuxt-cli/src/run-command.ts

@@ -12,7 +12,6 @@ export async function runCommandDef<T extends ArgsDef = ArgsDef>(
   argv: string[] = process.argv.slice(2),
   data: { overrides?: Record<string, any> } = {},
 ): Promise<{ result: unknown }> {
-  argv.push('--no-clear') // Dev
   if (command.meta && 'name' in command.meta && typeof command.meta.name === 'string') {
     const name = command.meta.name
     if (!(isNuxiCommand(name))) {

packages/nuxt-cli/src/run.ts

@@ -30,8 +30,6 @@ export async function runCommand(
   argv: string[] = process.argv.slice(2),
   data: { overrides?: Record<string, any> } = {},
 ): Promise<{ result: unknown }> {
-  argv.push('--no-clear') // Dev
-
   if (!(name in commands)) {
     throw new Error(`Invalid command ${name}`)
   }

packages/nuxt-cli/test/unit/run.spec.ts

@@ -0,0 +1,58 @@
+import { defineCommand } from 'citty'
+import { describe, expect, it, vi } from 'vitest'
+
+import { runCommandDef } from '../../src/run-command'
+
+let clear: boolean | undefined
+
+const devCommand = defineCommand({
+  meta: { name: 'dev' },
+  args: {
+    clear: {
+      type: 'boolean',
+      description: 'Clear console on restart',
+      default: false,
+    },
+  },
+  run(ctx) {
+    clear = ctx.args.clear
+  },
+})
+
+vi.mock('../../src/commands', () => ({
+  commands: {
+    dev: () => Promise.resolve(devCommand),
+  },
+}))
+
+describe('runCommand', () => {
+  it('should not clear the console unless asked to', async () => {
+    const { runCommand } = await import('../../src/run')
+
+    await runCommand('dev', [])
+    expect(clear).toBe(false)
+
+    await runCommandDef(devCommand, [])
+    expect(clear).toBe(false)
+  })
+
+  it('should respect an explicit `--clear`', async () => {
+    const { runCommand } = await import('../../src/run')
+
+    await runCommand('dev', ['--clear'])
+    expect(clear).toBe(true)
+
+    await runCommandDef(devCommand, ['--clear'])
+    expect(clear).toBe(true)
+  })
+
+  it('should not modify the arguments it is given', async () => {
+    const { runCommand } = await import('../../src/run')
+    const argv = ['--clear']
+
+    await runCommand('dev', argv)
+    await runCommandDef(devCommand, argv)
+
+    expect(argv).toEqual(['--clear'])
+  })
+})