Feature: Multi-Language Switcher Improvements#2403
Merged
1 commit merged intoAug 16, 2019
Merged
Conversation
Contributor
|
FYI this will conflict with #2392 |
Author
|
@XhmikosR：Thanks, either you or I will meet with the conflict and fix it later, whatever submit is merged. |
ghost
changed the title
ghost
self-requested a review
Contributor
|
BTW I was thinking the language switcher should be static in the templates.
Right now even if a page doesn't have a translation, the switcher shows all
of them.
Something to consider for the future maybe
…On Thu, Aug 15, 2019, 11:37 Maledong ***@***.***> wrote:
@XhmikosR <https://github.com/XhmikosR>：Thanks, either you or I will meet
with the conflict and fix it later, whatever submit is merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2403?email_source=notifications&email_token=AACVLNKZSBQXWMONU4SCORLQEUITRA5CNFSM4IL26DJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4LGSZY#issuecomment-521562471>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVLNKSVY3D6LYC3RK37ILQEUITRANCNFSM4IL26DJQ>
.
|
Author
Yes, but it would be nicer if we can show the current language as a tooltip for all of the users to see which language he/she is viewing with, and what's more, the picked language doesn't need to be shown in the menu list, unless you choose another one. That's my opition. For futher changes, maybe we can get together to change it little by little. |
1. Do not show the current choosen language unless your want to choose for a new one. 2. Show tooltip when moving your mouse onto the language symbol for the choosen language.
alexandrtovmach
approved these changes
Aug 15, 2019
3imed-jaberi
approved these changes
Aug 15, 2019
Aissaoui-Ahmed
approved these changes
Aug 15, 2019
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2019
Notice: This 'rect' is invisible as a container for the language symbol to show the tooltip in both IE and Chrome, FF,ect. For reasons of accessibility, user agents should always make the content of the 'title' child element to the root svg element available to users. However, this is typically done through other means than the tooltips used for nested SVG and graphics elements, e.g., by displaying in a browser tab. See more at: https://svgwg.org/svg2-draft/struct.html#TitleElement Issues and Subjects related to this are： 1、#2294. 2、#2403. 3、#2392.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.