Skip to content

Commit 3ae98ac

Browse files
committed
src: remove ignore GCC -Wcast-function-type for v8
This reverts Commit 3ff2aec ("src: ignore GCC -Wcast-function-type for v8.h") and Commit 2462a2c ("src: fix ignore GCC -Wcast-function-type for older compilers") as this has now been included in the V8 version being used. Refs: v8/v8@f08cbfd
1 parent 3f4ec9c commit 3ae98ac

File tree

3 files changed

+0
-21
lines changed

3 files changed

+0
-21
lines changed

src/base_object-inl.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,7 @@
2828
#include "env-inl.h"
2929
#include "util.h"
3030

31-
#if (__GNUC__ >= 8) && !defined(__clang__)
32-
#pragma GCC diagnostic push
33-
#pragma GCC diagnostic ignored "-Wcast-function-type"
34-
#endif
3531
#include "v8.h"
36-
#if (__GNUC__ >= 8) && !defined(__clang__)
37-
#pragma GCC diagnostic pop
38-
#endif
3932

4033
namespace node {
4134

src/node.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,7 @@
6060
# define SIGKILL 9
6161
#endif
6262

63-
#if (__GNUC__ >= 8) && !defined(__clang__)
64-
#pragma GCC diagnostic push
65-
#pragma GCC diagnostic ignored "-Wcast-function-type"
66-
#endif
6763
#include "v8.h" // NOLINT(build/include_order)
68-
#if (__GNUC__ >= 8) && !defined(__clang__)
69-
#pragma GCC diagnostic pop
70-
#endif
7164

7265
#include "v8-platform.h" // NOLINT(build/include_order)
7366
#include "node_version.h" // NODE_MODULE_VERSION

src/util.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,7 @@
2424

2525
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
2626

27-
#if (__GNUC__ >= 8) && !defined(__clang__)
28-
#pragma GCC diagnostic push
29-
#pragma GCC diagnostic ignored "-Wcast-function-type"
30-
#endif
3127
#include "v8.h"
32-
#if (__GNUC__ >= 8) && !defined(__clang__)
33-
#pragma GCC diagnostic pop
34-
#endif
3528

3629
#include <climits>
3730
#include <cstddef>

0 commit comments

Comments
 (0)