crypto: retain legacy DH validation

Limit the g >= p rejection needed by the provider backend to OpenSSL 3.
Preserve the legacy DiffieHellman object and expose the validation
result through verifyError as before.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #64547
Refs: #64211
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: panva

src/crypto/crypto_dh.cc

@@ -206,7 +206,7 @@ void New(const FunctionCallbackInfo<Value>& args) {
     }
   }
 
-#ifndef OPENSSL_IS_BORINGSSL
+#if NCRYPTO_USE_OPENSSL3_PROVIDER
   if (BN_num_bits(bn_p.get()) >= 512 && BN_cmp(bn_g.get(), bn_p.get()) >= 0) {
     PutDhError(DH_R_BAD_GENERATOR);
     return ThrowCryptoError(env, ERR_get_error(), "Invalid generator");

test/parallel/test-crypto-dh-curves.js

@@ -9,6 +9,7 @@ const { hasOpenSSL } = require('../common/crypto');
 const {
   DH_CHECK_P_NOT_PRIME,
   DH_CHECK_P_NOT_SAFE_PRIME,
+  DH_NOT_SUITABLE_GENERATOR,
 } = crypto.constants;
 
 // Second OAKLEY group, see
@@ -76,6 +77,11 @@ if (hasOpenSSL(3)) {
     () => crypto.createDiffieHellman(Buffer.from(p, 'hex'),
                                      Buffer.from(p, 'hex')),
     { code: 'ERR_OSSL_DH_BAD_GENERATOR' });
+} else if (!process.features.openssl_is_boringssl) {
+  assert.strictEqual(
+    crypto.createDiffieHellman(Buffer.from(p, 'hex'),
+                               Buffer.from(p, 'hex')).verifyError,
+    DH_NOT_SUITABLE_GENERATOR);
 }
 
 const availableCurves = new Set(crypto.getCurves());