fix: maintain all row spans after editing some cell#1662
Merged
jajugoguma merged 3 commits intomasterfrom May 4, 2022
Merged
Conversation
adhrinae
approved these changes
May 2, 2022
| Object.keys(rowSpanMap).forEach((columnName) => { | ||
| delete rowSpanMap[columnName]; | ||
| export function resetRowSpan({ data, column }: Store, slient = false) { | ||
| if (column.visibleRowSpanEnabledColumns.length > 0) { |
There was a problem hiding this comment.
저라면 들여쓰기를 한 번 더 하느니 early return을 할 것 같은데 다른 분들의 생각이 궁금하군요.
heenakwag
approved these changes
May 2, 2022
adhrinae
approved these changes
May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨