Skip to content

Commit 7779f71

Browse files
Xuanwosylvestre
authored andcommitted
feat: Enable logging for opendal operations
Signed-off-by: Xuanwo <github@xuanwo.io>
1 parent 2c13a72 commit 7779f71

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

src/cache/azure.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515

1616
use opendal::Operator;
1717

18+
use opendal::layers::LoggingLayer;
1819
use opendal::services::azblob;
1920

2021
use crate::errors::*;
@@ -27,6 +28,7 @@ impl AzureBlobCache {
2728
builder.container(container);
2829
builder.root(key_prefix);
2930

30-
Ok(builder.build()?.into())
31+
let op: Operator = builder.build()?.into();
32+
Ok(op.layer(LoggingLayer::default()))
3133
}
3234
}

src/cache/cache.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,9 @@ impl Storage for opendal::Operator {
335335
let hit = CacheRead::from(io::Cursor::new(res))?;
336336
Ok(Cache::Hit(hit))
337337
}
338+
Err(e) if e.kind() == opendal::ErrorKind::ObjectNotFound => Ok(Cache::Miss),
338339
Err(e) => {
339-
warn!("Got error: {:?}", e);
340+
warn!("Got unexpected error: {:?}", e);
340341
Ok(Cache::Miss)
341342
}
342343
}

src/cache/gcs.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
// limitations under the License.
1515

1616
use crate::errors::*;
17-
use opendal::services::gcs;
1817
use opendal::Operator;
18+
use opendal::{layers::LoggingLayer, services::gcs};
1919
use reqsign::{GoogleBuilder, GoogleToken, GoogleTokenLoad};
2020

2121
#[derive(Copy, Clone)]
@@ -67,7 +67,8 @@ impl GCSCache {
6767
}
6868
builder.signer(signer_builder.build()?);
6969

70-
Ok(builder.build()?.into())
70+
let op: Operator = builder.build()?.into();
71+
Ok(op.layer(LoggingLayer::default()))
7172
}
7273
}
7374

src/cache/s3.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
// See the License for the specific language governing permissions and
1111
// limitations under the License.
1212

13+
use opendal::layers::LoggingLayer;
1314
use opendal::services::s3;
1415
use opendal::Operator;
1516

@@ -41,7 +42,8 @@ impl S3Cache {
4142
builder.endpoint(&endpoint_resolver(endpoint, use_ssl)?);
4243
}
4344

44-
Ok(builder.build()?.into())
45+
let op: Operator = builder.build()?.into();
46+
Ok(op.layer(LoggingLayer::default()))
4547
}
4648
}
4749

0 commit comments

Comments
 (0)