From ab54bba51d179f15c317312cfee46ac7f01fc83d Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Mon, 1 Jul 2019 09:44:04 -0700 Subject: [PATCH 1/2] Fix broken python tests in news --- news/test_announce.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/news/test_announce.py b/news/test_announce.py index 54233e30115f..acc125a7c360 100644 --- a/news/test_announce.py +++ b/news/test_announce.py @@ -187,7 +187,8 @@ def fake_git_rm(path): def test_complete_news(): version = "2019.3.0" - date = datetime.date.today().strftime("%d %B %Y") + # Remove leading `0`. + date = datetime.date.today().strftime("%d %B %Y").lstrip("0") news = ann.complete_news(version, NEW_NEWS, f"{TITLE}\n\n\n{OLD_NEWS}") expected = f"{TITLE}\n\n## {version} ({date})\n\n{NEW_NEWS.strip()}\n\n\n{OLD_NEWS.strip()}" assert news == expected From 70aa3111c67c4f6d2989526ee9345578155d74ca Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Mon, 1 Jul 2019 09:55:50 -0700 Subject: [PATCH 2/2] Revert changes --- news/announce.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/news/announce.py b/news/announce.py index 71b2b5f48d7f..d4d7dd1cfd66 100644 --- a/news/announce.py +++ b/news/announce.py @@ -152,7 +152,8 @@ def complete_news(version, entry, previous_news): title, _, previous_news = previous_news.partition("\n") title = title.strip() previous_news = previous_news.strip() - section_title = f"## {version} ({datetime.date.today().strftime('%d %B %Y')})" + section_title = (f"## {version} ({datetime.date.today().strftime('%d %B %Y')})" + ).replace("(0", "(") # TODO: Insert the "Thank you!" section (in monthly releases)? return f"{title}\n\n{section_title}\n\n{entry.strip()}\n\n\n{previous_news}"