From 37e3407fea36a971403a6a10460ea39b4c41dcea Mon Sep 17 00:00:00 2001 From: gargsaumya Date: Mon, 16 Jun 2025 15:07:35 +0530 Subject: [PATCH] warnings should be caught as error --- mssql_python/pybind/CMakeLists.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mssql_python/pybind/CMakeLists.txt b/mssql_python/pybind/CMakeLists.txt index 8d42a5608..4c5567b73 100644 --- a/mssql_python/pybind/CMakeLists.txt +++ b/mssql_python/pybind/CMakeLists.txt @@ -286,6 +286,11 @@ target_compile_definitions(ddbc_bindings PRIVATE NOMINMAX ) +# Add warning level flags for MSVC +if(MSVC) + target_compile_options(ddbc_bindings PRIVATE /W4 /WX) +endif() + # Add macOS-specific string conversion fix if(APPLE) message(STATUS "Enabling macOS string conversion fix")