From 415faac7fd2e9d783777a5b1bda3531c870cbfec Mon Sep 17 00:00:00 2001 From: Emmanuel Oppong Date: Sun, 1 Nov 2026 08:14:00 -0600 Subject: [PATCH] Remove Thread.sleep from DefaultDelayingQueueTest simpleDelayingQueue waited a fixed 10 seconds before checking that the queue stayed empty. Poll until nothing is left waiting to be added instead, which is deterministic and takes the test from about 10.5s to about 0.5s. Part of #1223. --- .../client/extended/workqueue/DefaultDelayingQueueTest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/extended/src/test/java/io/kubernetes/client/extended/workqueue/DefaultDelayingQueueTest.java b/extended/src/test/java/io/kubernetes/client/extended/workqueue/DefaultDelayingQueueTest.java index f29791b688..5d4d9841a7 100644 --- a/extended/src/test/java/io/kubernetes/client/extended/workqueue/DefaultDelayingQueueTest.java +++ b/extended/src/test/java/io/kubernetes/client/extended/workqueue/DefaultDelayingQueueTest.java @@ -45,7 +45,9 @@ void simpleDelayingQueue() throws Exception { String item = queue.get(); queue.done(item); - Thread.sleep(10 * 1000L); + // The only entry was released above, so once nothing is left waiting to be added the queue + // cannot receive anything else. Poll for that instead of sleeping for a fixed 10 seconds. + assertThat(waitForWaitingQueueToFill(queue)).isTrue(); assertThat(0).isEqualTo(queue.length()); }