Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

feat: increase GRPC max metadata size to 4 MB#623

Merged
pradn merged 3 commits into
googleapis:mainfrom
pradn:eos-increase-grpc-metadata-limit
Mar 23, 2022
Merged

feat: increase GRPC max metadata size to 4 MB#623
pradn merged 3 commits into
googleapis:mainfrom
pradn:eos-increase-grpc-metadata-limit

Conversation

@pradn
Copy link
Copy Markdown
Contributor

@pradn pradn commented Mar 22, 2022

  • Ack/modack operations on subscriptions with exactly-once delivery enabled may return up to 4 MB of metadata (about ack/modack success/failure)
  • It's unclear what the current limit is (I searched far and wide), but it seems to be lower than 4 MB. So, we're currently seeing subscription StreamingPull stream closures as a result of this low limit. We aim to keep subscription the same for subscribers to exactly-once subscriptions, even if they don't use the new *with_response methods, so this fix ensures that.

@pradn pradn requested review from a team March 22, 2022 15:34
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants