Skip to content

fix: added proto message conversion to MDMJob.update fields#1718

Merged
rosiezou merged 23 commits into
mainfrom
mm-fix
Oct 19, 2022
Merged

fix: added proto message conversion to MDMJob.update fields#1718
rosiezou merged 23 commits into
mainfrom
mm-fix

Conversation

@rosiezou
Copy link
Copy Markdown
Contributor

@rosiezou rosiezou commented Oct 5, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<251194445> 🦕

@rosiezou rosiezou requested a review from a team October 5, 2022 20:19
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Oct 5, 2022
@rosiezou rosiezou requested a review from sasha-gitg October 5, 2022 21:30
@rosiezou rosiezou self-assigned this Oct 5, 2022
sasha-gitg
sasha-gitg requested changes Oct 6, 2022
View reviewed changes
Comment thread tests/unit/aiplatform/test_jobs.py Outdated
sasha-gitg
sasha-gitg requested changes Oct 7, 2022
View reviewed changes
Comment thread tests/unit/aiplatform/test_jobs.py Outdated
Comment thread tests/unit/aiplatform/test_jobs.py Outdated
@rosiezou
Copy link
Copy Markdown
Contributor Author

rosiezou commented Oct 7, 2022

Closing this PR for now. Will re-open once SDK maintenance work is completed.

@rosiezou rosiezou closed this Oct 7, 2022
@rosiezou rosiezou reopened this Oct 17, 2022
rosiezou
rosiezou commented Oct 18, 2022
View reviewed changes
Comment thread tests/unit/aiplatform/test_jobs.py
sasha-gitg
sasha-gitg requested changes Oct 18, 2022
View reviewed changes
Comment thread google/cloud/aiplatform/jobs.py Outdated
Comment thread google/cloud/aiplatform/jobs.py Outdated
Comment thread tests/unit/aiplatform/test_jobs.py Outdated
sasha-gitg
sasha-gitg requested changes Oct 18, 2022
View reviewed changes
Comment thread google/cloud/aiplatform/jobs.py Outdated
Comment thread google/cloud/aiplatform/jobs.py Outdated
Comment thread google/cloud/aiplatform/jobs.py Outdated
sasha-gitg
sasha-gitg approved these changes Oct 19, 2022
View reviewed changes
Comment thread google/cloud/aiplatform/jobs.py Outdated
@rosiezou rosiezou merged commit 9e77c61 into main Oct 19, 2022
@rosiezou rosiezou deleted the mm-fix branch October 19, 2022 21:44
@release-please release-please Bot mentioned this pull request Oct 19, 2022
Merged
@release-please release-please Bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please Bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please Bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees

@rosiezou rosiezou

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rosiezou @sasha-gitg